Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create trusted-web-activity-browser-support.md #129

Merged
merged 2 commits into from
Jul 29, 2020
Merged

Conversation

andreban
Copy link
Member

Kicks off a document mapping Trusted Web Activity support across browsers.

Kicks off a document mapping Trusted Web Activity support across browsers.
Trusted Web Activity Browser Support
====================================

**Important:** This is an unnofficial list of Trusted Web Activity support across
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're in a repo owned by "GoogleChrome", can this really be unofficial?

Why are we saying it's unofficial? In case there are mistakes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can definitely keep the Chrome details updated, but not other vendors. Maybe we can word this differently?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "We do our best to keep this up to date - if you spot anything missing or incorrect, please file an issue at XX".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated


**Important:** This is an unnofficial list of Trusted Web Activity support across
browsers. The list is not exhaustive and is maintained by the community.
Please file an [issue][14] if the information is incorrect, incomplete of if you'd
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File an issue or a pull request? Are we (most likely you) going to end up manually verifying everything?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An issue sounds like a good first step? PRs are definitely welcome, but issues may be easier to file and have a quick chat. (I definitely don't plan to manually verify everything)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be worth having an Issue template for this specifically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be - I'll waiting until we start getting issues on this and then we can map what would be useful to have on the template.

@andreban andreban requested a review from PEConn July 28, 2020 18:18
Copy link
Collaborator

@PEConn PEConn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@andreban andreban merged commit 49c0cd5 into master Jul 29, 2020
@andreban andreban deleted the andreban-twa-support branch August 15, 2020 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants