Seperate ports for production and dev #65
Conversation
| const PROD_PORT = 8080; | ||
| const DEV_PORT = 8081; | ||
| // This results in different ports for prod and dev | ||
| var port = (GLOBAL.config.env === 'prod') ? PROD_PORT : DEV_PORT; |
There was a problem hiding this comment.
I wasn't very clear in #64 (comment)
Some hosting providers (at least Heroku and App Engine, though it's probably more than those) require that your Node.js server listens on whatever they set process.env.PORT to. I think they want the flexibility to start up your process on whatever port they choose, based on whatever restrictions they have in place.
So what I'd suggest is to always use process.env.PORT if it's already set, and if it's not set, then use one port number for 'prod' and a separate port number for 'dev'.
Maybe something like var port = process.env.PORT || ((GLOBAL.config.env === 'prod') ? PROD_PORT : DEV_PORT);
There was a problem hiding this comment.
Well this only applies to the gulp build. If heroku where to start the server, it would be starting node app.js presumably on a prebuilt version of the front end.
From this app.js would use process.env.PORT - i.e. what ever heroku set.
The scenario I haven't accounted for is if the process.env.PORT is defined although running node app.js will select a random port (or so it seems).
|
@jeffposnick Had a think on this and made a few small tweaks. 1.) Ports are defined in the gulpfile.js now (easier and more obvious where to set these). cc @addyosmani |
|
👍 |
Seperate ports for production and dev
As per #64 idea, PR to do exactly that.
I've avoided a random port for dev server simply because nodemon will restart the server and having a random port assigned each time sounds like a pain to me.
cc @addyosmani @jeffposnick