Attach debugger only when panel is opened. #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-vogler
force-pushed
the
late-debugger
branch
from
58d0c30
to
091ed26
Compare
max-vogler
commented
Sep 23, 2021
| chrome.debugger.onDetach.addListener(onDetach); | ||
| chrome.debugger.onEvent.addListener(onEvent); | ||
| chrome.devtools.network.onNavigated.addListener(onNavigated); |
There was a problem hiding this comment.
@mzgoddard: Is there a specific reason for re-enabling the debugging through sendCommand when onNavigated is triggered? Even after removing the code, Web Audio DevTools works when navigating between different pages.
max-vogler
changed the title
hoch
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, audion would attach the debugger as soon as any devtools panel is opened - this would show the browser's warning bar even before the user opened the DevTools panel. This PR delays attaching the debugger until the user actually opens the audion panel for the first time.
Fixes #105