New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
devtools-page: connect to and process webaudio debugger events #97
Conversation
Connect to WebAudio chrome debugger protocol domain and collect events into a larger AudioContext "graph". This object is collects the events into a current representation of WebAudio graphs in the inspected window. A graphlib graph will be derived from this information in a future change. - Add and test some internal utilities - Observer - Observer.throttle Used to limit the frequency of WebAudio representations to later process steps. - invariant - Add and test some types to process events - DevtoolsGraphPanel Create a chrome devtools panel and post graph updates to the panel. - WebAudioEventObserver Attach to chrome debugger api and forward WebAudio domain events. - WebAudioGraphIntegrator Collect WebAudio events into a current representation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before proceeding further, it might be beneficial to clear up a few things:
- "Debugger" is such loaded term. "Inspector" seems a bit better.
- An overview comment per each file would be greatly appreciated!
Also can we have a README file in the project root? Some documentations on the installation/local development would be helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looking forward to the next PR!
Connect to WebAudio chrome debugger protocol domain and collect events
into a larger AudioContext "graph". This object is collects the events
into a current representation of WebAudio graphs in the inspected
window. A graphlib graph will be derived from this information in a
future change.
Used to limit the frequency of WebAudio representations to later
process steps.
Create a chrome devtools panel and post graph updates to the panel.
Attach to chrome debugger api and forward WebAudio domain events.
Collect WebAudio events into a current representation.