Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devtools-page: connect to and process webaudio debugger events #97

Merged
merged 9 commits into from Aug 6, 2021

Conversation

mzgoddard
Copy link
Collaborator

Connect to WebAudio chrome debugger protocol domain and collect events
into a larger AudioContext "graph". This object is collects the events
into a current representation of WebAudio graphs in the inspected
window. A graphlib graph will be derived from this information in a
future change.

  • Add and test some internal utilities
    • Observer
    • Observer.throttle
      Used to limit the frequency of WebAudio representations to later
      process steps.
    • invariant
  • Add and test some types to process events
    • DevtoolsGraphPanel
      Create a chrome devtools panel and post graph updates to the panel.
    • WebAudioEventObserver
      Attach to chrome debugger api and forward WebAudio domain events.
    • WebAudioGraphIntegrator
      Collect WebAudio events into a current representation.

Connect to WebAudio chrome debugger protocol domain and collect events
into a larger AudioContext "graph". This object is collects the events
into a current representation of WebAudio graphs in the inspected
window. A graphlib graph will be derived from this information in a
future change.

- Add and test some internal utilities
  - Observer
  - Observer.throttle
    Used to limit the frequency of WebAudio representations to later
    process steps.
  - invariant
- Add and test some types to process events
  - DevtoolsGraphPanel
    Create a chrome devtools panel and post graph updates to the panel.
  - WebAudioEventObserver
    Attach to chrome debugger api and forward WebAudio domain events.
  - WebAudioGraphIntegrator
    Collect WebAudio events into a current representation.
@mzgoddard mzgoddard requested a review from hoch July 22, 2021 14:57
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before proceeding further, it might be beneficial to clear up a few things:

  1. "Debugger" is such loaded term. "Inspector" seems a bit better.
  2. An overview comment per each file would be greatly appreciated!

src/chrome/Debugger.js Show resolved Hide resolved
src/chrome/Runtime.js Show resolved Hide resolved
src/devtools/DevtoolsGraphPanel.js Show resolved Hide resolved
@hoch
Copy link
Member

hoch commented Jul 28, 2021

Also can we have a README file in the project root? Some documentations on the installation/local development would be helpful.

Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looking forward to the next PR!

@mzgoddard mzgoddard merged commit 96156aa into dev Aug 6, 2021
@mzgoddard mzgoddard deleted the mzgoddard-devtools-page branch August 6, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants