Skip to content

Commit

Permalink
test: use strict version of assert functions (#201)
Browse files Browse the repository at this point in the history
  • Loading branch information
G-Rath committed May 16, 2020
1 parent c68e180 commit 88e4968
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 4 additions & 4 deletions test/chrome-launcher-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -77,15 +77,15 @@ describe('Launcher', () => {
const chromeInstance = new Launcher({userDataDir: 'some_path'}, {fs: fsMock as any});

chromeInstance.prepare();
assert.equal(chromeInstance.userDataDir, 'some_path');
assert.strictEqual(chromeInstance.userDataDir, 'some_path');
});

it('defaults to genering a tmp dir when no data dir is passed', () => {
const chromeInstance = new Launcher({}, {fs: fsMock as any});
const originalMakeTmp = chromeInstance.makeTmpDir;
chromeInstance.makeTmpDir = () => 'tmp_dir'
chromeInstance.prepare()
assert.equal(chromeInstance.userDataDir, 'tmp_dir');
assert.strictEqual(chromeInstance.userDataDir, 'tmp_dir');

// Restore the original fn.
chromeInstance.makeTmpDir = originalMakeTmp;
Expand Down Expand Up @@ -155,14 +155,14 @@ describe('Launcher', () => {
it('passes no env vars when none are passed', async () => {
const spawnStub = await launchChromeWithOpts();
const spawnOptions = spawnStub.getCall(0).args[2] as {env: {}};
assert.deepEqual(spawnOptions.env, Object.assign({}, process.env));
assert.deepStrictEqual(spawnOptions.env, Object.assign({}, process.env));
});

it('passes env vars when passed', async () => {
const envVars = {'hello': 'world'};
const spawnStub = await launchChromeWithOpts({envVars});
const spawnOptions = spawnStub.getCall(0).args[2] as {env: {}};
assert.deepEqual(spawnOptions.env, envVars);
assert.deepStrictEqual(spawnOptions.env, envVars);
});

it('ensure specific flags are present when passed and defaults are ignored', async () => {
Expand Down
8 changes: 4 additions & 4 deletions test/launch-signature-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ describe('Launcher', () => {
it('exposes expected interface when launched', async () => {
this.timeout = 3500;
const chrome = await launch();
assert.notEqual(chrome.process, undefined);
assert.notEqual(chrome.pid, undefined);
assert.notEqual(chrome.port, undefined);
assert.notEqual(chrome.kill, undefined);
assert.notStrictEqual(chrome.process, undefined);
assert.notStrictEqual(chrome.pid, undefined);
assert.notStrictEqual(chrome.port, undefined);
assert.notStrictEqual(chrome.kill, undefined);
await chrome.kill();
});
});

0 comments on commit 88e4968

Please sign in to comment.