Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pass environment variables for launched Chrome process (to set TZ) #29

Closed
samir-mahendra opened this issue Sep 21, 2017 · 2 comments
Closed

Add ability to pass environment variables for launched Chrome process (to set TZ) #29

samir-mahendra opened this issue Sep 21, 2017 · 2 comments

Comments

@samir-mahendra
Copy link

I have a use case where I need to launch Chrome with a different "TZ" variable than the one the environment is running under.

While I can do this in my launching Node process, it would make my script easier if I had a way to pass TZ into the launcher.

If you accept env as a launcher option, it would then get passed along into spawn command here: https://github.com/GoogleChrome/chrome-launcher/blob/master/chrome-launcher.ts#L220

Format of env argument could be something like this for example:

env: { 'TZ': 'America/New_York'}
@BenoitZugmeyer BenoitZugmeyer mentioned this issue Sep 29, 2017
Merged
samccone added a commit that referenced this issue Dec 6, 2017
@samccone
Enable users to pass env vars into spawned chrome.
8674ce3 
Since it can be useful for users to programatically set env vars
for a given instance of chrome, expose the ability for users to pass
in a env dict into the spawn command that is used to launch chrome.

FIXES #29
@samccone
Copy link
Contributor

samccone commented Dec 6, 2017

Thanks so much for reaching out @samir-mahendra I have gone ahead and opened a PR to address this.

@samccone samccone mentioned this issue Dec 6, 2017
Merged
samccone added a commit that referenced this issue Dec 6, 2017
@samccone
Enable users to pass env vars into spawned chrome.
9993887 
Since it can be useful for users to programatically set env vars
for a given instance of chrome, expose the ability for users to pass
in a env dict into the spawn command that is used to launch chrome.

FIXES #29
samccone added a commit that referenced this issue Dec 6, 2017
@samccone
Enable users to pass env vars into spawned chrome.
c75f633 
Since it can be useful for users to programatically set env vars
for a given instance of chrome, expose the ability for users to pass
in a env dict into the spawn command that is used to launch chrome.

FIXES #29
samccone added a commit that referenced this issue Dec 6, 2017
@samccone
Enable users to pass env vars into spawned chrome.
ee36498 
Since it can be useful for users to programatically set env vars
for a given instance of chrome, expose the ability for users to pass
in a env dict into the spawn command that is used to launch chrome.

FIXES #29
samccone added a commit that referenced this issue Dec 6, 2017
@samccone
Enable users to pass env vars into spawned chrome.
3f31cc5 
Since it can be useful for users to programatically set env vars
for a given instance of chrome, expose the ability for users to pass
in a env dict into the spawn command that is used to launch chrome.

FIXES #29
@paulirish
Copy link
Member

shipped in 0.10.0

@tmm1 tmm1 mentioned this issue Jul 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@paulirish @samccone @samir-mahendra