-
Notifications
You must be signed in to change notification settings - Fork 1.6k
How much is the existing article markup going to remain the same? #2
Comments
cc @Meggin |
Here's an example of some trouble: The chrome.com link color is black. With body text of grey. So then, in the new design, these bolded text elements are black, and look just like the links. I think it'd be best for there not to be random words bolded in the text. If emphasis is needed then you can use <em>, and that will visually display as italic. Or what do you think, Chrome team? |
@peterlubbers can we flag links being black asap? |
I hate that links moved from blue -> black. You don't know what is what and On Tue, Nov 12, 2013 at 3:50 PM, Jen Simmons notifications@github.comwrote:
|
Yeah, I agree, actually. Links being black might work great on a product promo website, where the content is very sparse and there's rarely an inline link. But for documentation, it really makes the links blend in. A blue might be much better. |
Sent mail about it to Zhu Peter Lubbers On Tue, Nov 12, 2013 at 3:56 PM, Eric Bidelman notifications@github.comwrote:
|
* Adds 'meet the team' card to the homepage * Refactors the new card using the existing featured-card macro * Minor content fix * Minor content fix #2 * Removes now redundant items from events i18n * Fixes contrast issue for cards with a yellow bg * Fixes linter issue
* move topics API questions out of FAQ * move topics API questions out of FAQ into fedCM and fenced frames * remove incorrect section * remove redundant feedback links--move into docs * move client hints content * move final questions * edit faq * touchup * touchup * fix fig caption * fix table headers * fix table headers * fix table headers * fix table headers * fix table headers, remove styles * fix table headers, remove styles * fix table headers, remove styles * fix table headers, remove styles * fix typo * remove note in aside Co-authored-by: Alexandra White <alexandrawhite@google.com>
As noted in another issue, I'm looking at the markup of the main content on this page: https://developers.google.com/chrome-developer-tools/docs/elements
Hm.
The <p> tags aren't nested properly in places. And both <b> and <strong> are being used in ways that aren't quite correct semantically. And images are marked-up with extraneous divs that we don't need.
How much will there be a chance to clean stuff like this up in the conversion? Or is this markup something consistent and universal that we should support with the new CSS, and just live with? Or is it something that we'll have to live with, but that isn't standardized across pages / not something to "support" because there are a lot of little inconsistent errors created manually over years…
Ah, life. And pickiness.
The text was updated successfully, but these errors were encountered: