Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

How much is the existing article markup going to remain the same? #2

Closed
jensimmons opened this issue Nov 12, 2013 · 6 comments
Closed

Comments

@jensimmons
Copy link

As noted in another issue, I'm looking at the markup of the main content on this page: https://developers.google.com/chrome-developer-tools/docs/elements

Hm.

The <p> tags aren't nested properly in places. And both <b> and <strong> are being used in ways that aren't quite correct semantically. And images are marked-up with extraneous divs that we don't need.

How much will there be a chance to clean stuff like this up in the conversion? Or is this markup something consistent and universal that we should support with the new CSS, and just live with? Or is it something that we'll have to live with, but that isn't standardized across pages / not something to "support" because there are a lot of little inconsistent errors created manually over years…

Ah, life. And pickiness.

@ebidel
Copy link
Contributor

ebidel commented Nov 12, 2013

cc @Meggin

@jensimmons
Copy link
Author

Here's an example of some trouble:

The chrome.com link color is black. With body text of grey.

So then, in the new design, these bolded text elements are black, and look just like the links.

developers chrome com 2013-11-12 18-49-06

I think it'd be best for there not to be random words bolded in the text. If emphasis is needed then you can use <em>, and that will visually display as italic.

Or what do you think, Chrome team?

@ebidel
Copy link
Contributor

ebidel commented Nov 12, 2013

@peterlubbers can we flag links being black asap?

@ebidel
Copy link
Contributor

ebidel commented Nov 12, 2013

I hate that links moved from blue -> black. You don't know what is what and
subheadings are looking exactly like links. I'm surprised we didn't catch
this today.

On Tue, Nov 12, 2013 at 3:50 PM, Jen Simmons notifications@github.comwrote:

Here's an example of some trouble:

The chrome.com link color is black. With body text of grey.

So then, in the new design, these bolded text elements are black, and look
just like the links.

[image: developers chrome com 2013-11-12 18-49-06]https://f.cloud.github.com/assets/108474/1527421/0333446e-4bf5-11e3-85f1-36b1b3cc8b3b.png

I think it'd be best for there not to be random words bolded in the text.
If emphasis is needed then you can use , and that will visually display
as italic.

Or what do you think, Chrome team?


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-28346839
.

@jensimmons
Copy link
Author

Yeah, I agree, actually. Links being black might work great on a product promo website, where the content is very sparse and there's rarely an inline link. But for documentation, it really makes the links blend in. A blue might be much better.

@peterlubbers
Copy link

Sent mail about it to Zhu

Peter Lubbers
Author, Pro HTML5 Programming
http://www.amazon.com/gp/product/143023864X/ref=as_li_ss_tl?ie=UTF8&camp=1789&creative=390957&creativeASIN=143023864X&linkCode=as2&tag=rulata-20
,
2nd Edition (Apress, 2011)
Twitter https://twitter.com/peterlubbers |
G+https://plus.google.com/u/0/112811650518962267774|
LinkedIn http://www.linkedin.com/in/peterlubbers |
SFHTML5http://www.sfhtml5.org/

On Tue, Nov 12, 2013 at 3:56 PM, Eric Bidelman notifications@github.comwrote:

@peterlubbers https://github.com/peterlubbers can we flag links being
black asap?


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-28347169
.

@ebidel ebidel closed this as completed Dec 6, 2013
johnrich85 added a commit that referenced this issue Nov 23, 2022
johnrich85 added a commit that referenced this issue Nov 28, 2022
devnook pushed a commit that referenced this issue Nov 28, 2022
* Adds 'meet the team' card to the homepage

* Refactors the new card using the existing featured-card macro

* Minor content fix

* Minor content fix #2

* Removes now redundant items from events i18n

* Fixes contrast issue for cards with a yellow bg

* Fixes linter issue
nancymic2 added a commit that referenced this issue Mar 13, 2023
alexandrascript added a commit that referenced this issue Mar 14, 2023
* move topics API questions out of FAQ

* move topics API questions out of FAQ into fedCM and fenced frames

* remove incorrect section

* remove redundant feedback links--move into docs

* move client hints content

* move final questions

* edit faq

* touchup

* touchup

* fix fig caption

* fix table headers

* fix table headers

* fix table headers

* fix table headers

* fix table headers, remove styles

* fix table headers, remove styles

* fix table headers, remove styles

* fix table headers, remove styles

* fix typo

* remove note in aside

Co-authored-by: Alexandra White <alexandrawhite@google.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants