Chromium Chronicle 20 #682
Conversation
|
Deploy preview for developer-chrome-com failed. Built with commit f628576 https://app.netlify.com/sites/developer-chrome-com/deploys/608846f71e33c20008394665 |
pullapprove
bot
requested review from
awfuchs,
jpmedley,
mihajlija and
rachelandrew
| **Episode 20:** by John Chen in Bellevue, WA (April, 2021)<br> | ||
| [Previous episodes](/tags/chromium-chronicle/) | ||
|
|
||
| Speed is one of Chrome's four core principles. **Adding benchmarks is an |
There was a problem hiding this comment.
| Speed is one of Chrome's four core principles. **Adding benchmarks is an | |
| Speed is one of Chrome's four core principles and has several benefits. | |
| **Adding benchmarks is an |
| new feature's performance. | ||
|
|
||
| **Benchmarks run regularly in the lab.** When a regression is found, bisect | ||
| automatically finds the culprit CL and a bug is assigned to the CL owner. |
There was a problem hiding this comment.
| automatically finds the culprit CL and a bug is assigned to the CL owner. | |
| automatically finds the culprit CL and assigns a bug to the CL owner. |
| Use Blink Perf for one off cases that don't fit into other harnesses. In | ||
| Blink Perf, you can measure trace events on one-off pages. | ||
|
|
||
| **Keep your benchmark stories simple** and only include the minimal set of |
There was a problem hiding this comment.
You've transitioned from a list of benefits to giving advice, but I didn't get text that introduces the shift.
There was a problem hiding this comment.
At least put in a heading so that I'm not confused.
Co-authored-by: Joe Medley <jmedley@google.com>
| Use Blink Perf for one off cases that don't fit into other harnesses. In | ||
| Blink Perf, you can measure trace events on one-off pages. | ||
|
|
||
| **Keep your benchmark stories simple** and only include the minimal set of |
There was a problem hiding this comment.
At least put in a heading so that I'm not confused.
|
@samthor - this is failing the lint test because of someone elses file, nothing that I checked in/changed... |
|
Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated. TESTING! THIS IS A DEVELOPMENT BUILD OF REVIEWBOT. Requested changesIf there are any common problems with the content files you created or modified, they will be listed here.
|
Changes proposed in this pull request: