Merge pull request #213 from hadriann/patch-nearest-dialog

Fix detection of nearest dialog for shadow DOM usage (#189)
GoogleChrome · Jan 7, 2021 · 75df500 · 75df500
2 parents cd2f547 + fa3ba8c
commit 75df500
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 5 deletions.
diff --git a/dist/dialog-polyfill.esm.js b/dist/dialog-polyfill.esm.js
@@ -64,7 +64,13 @@ function findNearestDialog(el) {
     if (el.localName === 'dialog') {
       return /** @type {HTMLDialogElement} */ (el);
     }
-    el = el.parentElement;
+    if (el.parentElement) {
+      el = el.parentElement;
+    } else if (el.parentNode) {
+      el = el.parentNode.host;
+    } else {
+      el = null;
+    }
   }
   return null;
 }

diff --git a/dist/dialog-polyfill.js b/dist/dialog-polyfill.js
@@ -70,7 +70,13 @@
       if (el.localName === 'dialog') {
         return /** @type {HTMLDialogElement} */ (el);
       }
-      el = el.parentElement;
+      if (el.parentElement) {
+        el = el.parentElement;
+      } else if (el.parentNode) {
+        el = el.parentNode.host;
+      } else {
+        el = null;
+      }
     }
     return null;
   }

diff --git a/index.js b/index.js
@@ -65,7 +65,13 @@ function findNearestDialog(el) {
     if (el.localName === 'dialog') {
       return /** @type {HTMLDialogElement} */ (el);
     }
-    el = el.parentElement;
+    if (el.parentElement) {
+      el = el.parentElement;
+    } else if (el.parentNode) {
+      el = el.parentNode.host;
+    } else {
+      el = null;
+    }
   }
   return null;
 }

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "dialog-polyfill",
-  "version": "0.5.4",
+  "version": "0.5.5",
   "description": "Polyfill for the dialog element",
   "main": "dist/dialog-polyfill.js",
   "module": "dist/dialog-polyfill.esm.js",