fix(server): only metrics get numeric diff view

GoogleChrome · Oct 3, 2019 · 98b0ca2 · 98b0ca2
1 parent 2e9a282
commit 98b0ca2
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/packages/server/src/ui/routes/build-view/audit-list/audit-group.jsx b/packages/server/src/ui/routes/build-view/audit-list/audit-group.jsx
@@ -12,7 +12,7 @@ import clsx from 'clsx';
 import {AuditDiff} from './audit-diff';
 
 /**
- * @param {{key?: string, group: {title: string}, selectedAuditId: string|null, setSelectedAuditId: (id: string|null) => void, pairs: Array<LHCI.AuditPair>, baseLhr?: LH.Result, variant?: 'standard'|'numeric'}} props
+ * @param {{key?: string, group: {id: string, title: string}, selectedAuditId: string|null, setSelectedAuditId: (id: string|null) => void, pairs: Array<LHCI.AuditPair>, baseLhr?: LH.Result, variant?: 'standard'|'numeric'}} props
  */
 export const AuditGroup = props => {
   const {group, pairs} = props;
@@ -24,6 +24,11 @@ export const AuditGroup = props => {
         {pairs.map(pair => {
           const {audit} = pair;
 
+          // Only metrics are allowed to display the numericValue diff in this view.
+          if (group.id !== 'metrics') {
+            pair = {...pair, diffs: pair.diffs.filter(diff => diff.type !== 'numericValue')};
+          }
+
           return (
             <div
               key={audit.id}

diff --git a/packages/server/src/ui/routes/build-view/build-view.jsx b/packages/server/src/ui/routes/build-view/build-view.jsx
@@ -46,7 +46,7 @@ function computeAuditGroups(lhr, baseLhr) {
         const audits = auditRefGroup
           .map(ref => ({...lhr.audits[ref.id], id: ref.id}))
           .sort((a, b) => (a.score || 0) - (b.score || 0));
-        return {id: groupId, group, audits};
+        return {id: groupId, group: {...group, id: groupId}, audits};
       });
     })
     .reduce((a, b) => a.concat(b));
@@ -80,8 +80,8 @@ function computeAuditGroups(lhr, baseLhr) {
   return auditGroups;
 }
 
-/** @typedef {{id: string, audits: Array<LH.AuditResult>, group: {title: string}}} IntermediateAuditGroupDef */
-/** @typedef {{id: string, pairs: Array<LHCI.AuditPair>, group: {title: string}}} AuditGroupDef */
+/** @typedef {{id: string, audits: Array<LH.AuditResult>, group: {id: string, title: string}}} IntermediateAuditGroupDef */
+/** @typedef {{id: string, pairs: Array<LHCI.AuditPair>, group: {id: string, title: string}}} AuditGroupDef */
 
 /** @param {{selectedUrl: string, setUrl(url: string): void, build: LHCI.ServerCommand.Build | null, lhr?: LH.Result, baseLhr?: LH.Result, urls: Array<string>}} props */
 const BuildViewScoreAndUrl = props => {