tests(cli): merge conflicts resolved with start server command

GoogleChrome · Nov 8, 2019 · c18364f · c18364f
1 parent 0e62625
commit c18364f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/packages/cli/test/cli.test.js b/packages/cli/test/cli.test.js
@@ -166,18 +166,14 @@ describe('Lighthouse CI CLI', () => {
 
     it('should collect results with a server command', () => {
       const startCommand = `yarn start server -p=14927 --storage.sqlDatabasePath=${tmpSqlFilePath}`;
-      let {stdout = '', stderr = '', status = -1} = spawnSync(CLI_PATH, [
+      const {stdout, stderr, status} = runCLI([
         'collect',
         `-n=1`,
         `--rc-file=${rcFile}`,
         `--start-server-command=${startCommand}`,
         `--url=http://localhost:14927/app/`,
       ]);
 
-      stdout = stdout.toString();
-      stderr = stderr.toString();
-      status = status || 0;
-
       const stdoutClean = stdout
         .replace(/:\d{4,6}/g, ':XXXX')
         .replace(/sqlDatabasePath=.*?"/, 'sqlDatabasePath=<file>"');

diff --git a/packages/utils/src/child-process-helper.js b/packages/utils/src/child-process-helper.js
@@ -72,7 +72,10 @@ function getListOfRunningCommands() {
     .spawnSync('ps', ['aux'])
     .stdout.toString()
     .split('\n')
-    .map(line => line.split(/\d+:\d+\.\d+/)[1])
+    .map(line => {
+      const matches = line.split(/\s+\d+:\d+(\.\d+)?/g);
+      return matches && matches[matches.length - 1];
+    })
     .filter(Boolean)
     .map(command => command.trim());
 }

diff --git a/packages/utils/test/child-process-helper.test.js b/packages/utils/test/child-process-helper.test.js
@@ -22,7 +22,7 @@ async function tryUntilPasses(fn, timeout = 5000) {
       await fn();
       return;
     } catch (err) {
-      lastError = error;
+      lastError = err;
       await wait();
     }
   }