chore: bump to node 18 (#989)

BREAKING CHANGE: minimum supported node is now 18
GoogleChrome · Dec 14, 2023 · c5bde95 · c5bde95
1 parent 5d30e52
commit c5bde95
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -23,10 +23,10 @@ jobs:
         uses: actions/checkout@v3
         with:
           fetch-depth: 0
-      - name: Use Node.js 16.x
+      - name: Use Node.js 18.16
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.16
           cache: yarn
       - run: yarn install --frozen-lockfile
       - run: yarn build
@@ -71,10 +71,10 @@ jobs:
         uses: actions/checkout@v3
         with:
           fetch-depth: 0
-      - name: Use Node.js 16.x
+      - name: Use Node.js 18.16
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version: 18.16
           cache: yarn
       - name: Configure Environment
         run: |-

diff --git a/README.md b/README.md
@@ -20,7 +20,7 @@ jobs:
       - uses: actions/checkout@v3
       - uses: actions/setup-node@v3
         with:
-          node-version: 16
+          node-version: 18
       - run: npm install && npm install -g @lhci/cli@0.12.x
       - run: npm run build
       - run: lhci autorun

diff --git a/docs/recipes/docker-client/Dockerfile b/docs/recipes/docker-client/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:16-bullseye-slim
+FROM node:18-bullseye-slim
 
 # Set variable so puppeteer will not try to download chromium
 ENV PUPPETEER_SKIP_DOWNLOAD=true

diff --git a/docs/recipes/docker-server/Dockerfile b/docs/recipes/docker-server/Dockerfile
@@ -1,4 +1,4 @@
-FROM node:16-bullseye-slim
+FROM node:18-bullseye-slim
 
 # Install utilities
 RUN apt-get update --fix-missing && apt-get install -y python build-essential && apt-get clean

diff --git a/packages/cli/test/collect-psi.test.js b/packages/cli/test/collect-psi.test.js
@@ -69,7 +69,8 @@ describe('Lighthouse CI collect CLI using PSI', () => {
     `);
     expect(stderr).toMatchInlineSnapshot(`
       "Error: PSI Failed (UNKNOWN): Oops
-          at PsiClient.run"
+          at PsiClient.run
+          at process.processTicksAndRejections"
     `);
     expect(status).toEqual(1);
   }, 180000);