Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"no change" on -51ms item #31

Closed
paulirish opened this issue Oct 22, 2019 · 3 comments
Closed

"no change" on -51ms item #31

paulirish opened this issue Oct 22, 2019 · 3 comments

Comments

@paulirish
Copy link
Member

image
https://lhci-canary.herokuapp.com/app/projects/d819a1f6-2630-4ee8-a451-95e369fec825/builds/80872396-61cc-46b0-ae98-ddeb705ea990?baseHash=006657567ad7fdd6d71f8041c3f9b9baeca50225

how can it have no change if there is a change? :)

also.. are we currently sorting within the groups? seems like we're not sorted within 'better' here, right?

@patrickhulce
Copy link
Collaborator

how can it have no change if there is a change? :)

if it's below the change threshold you've selected :) (5% by default and admittedly unlabeled at the moment, but yuin is on the case!)

also.. are we currently sorting within the groups? seems like we're not sorted within 'better' here, right?

correct, added to #9 👍

@patrickhulce
Copy link
Collaborator

we decided to add the percentage to each cell in addition to the delta

@patrickhulce
Copy link
Collaborator

fixed by 2f0fb8e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants