Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript error on LHCI Server when selecting an audit node to compare #618

Closed
dkarzon opened this issue Jun 2, 2021 · 3 comments
Closed
Assignees
Labels
bug Something isn't working P1

Comments

@dkarzon
Copy link

dkarzon commented Jun 2, 2021

Describe the bug
When comparing 2 runs clicking on an audit node throws a javascript error: TypeError: Cannot read property 'snippet' of undefined and does not open the sidebar for detailed comparison.

To Reproduce
Steps to reproduce the behavior:

  1. Open a project and click on the latest build from the builds list to compare it to the previous.
  2. Scroll down and click on 1 of the audit nodes (ie. "Total Blocking Time" under the Metrics header. Though the error happens when clicking on any)
  3. See error in console

Expected behavior
The detailed view sidebar pops out to show more info on the selected item.

Logs/Screenshots
image

Environment (Server):

  • OS: AWS Fargate (docker)
  • LHCI Server Version: 0.7.2
  • Data storage: PostgreSQL (AWS RDS)

Environment (Runner):

  • OS: Bitbucket Pipelines (Image: node:12.17-alpine3.11)
  • LHCI CLI Version: 0.7.2

Environment (Client):

  • OS: Windows 10
  • Browser1: Chrome v90.0.4430.212
  • Browser2: Edge v91.0.864.3

Additional context
This error only happens for 1 of the projects I have setup on this server (all are run from the same bitbucket pipeline instead all with the same versions). Attaching Lighthouse report JSON to recreate the issue.

Link to lhr json (2021-06-01): https://drive.google.com/file/d/1deL6yTsaQvgxtFLQpLbIXlAEUemvydxe/view?usp=sharing
Link to lhr json (2021-05-31): https://drive.google.com/file/d/1m28T_qLrvucocqTdW-zNSrHqcSIVS15D/view?usp=sharing

@patrickhulce
Copy link
Collaborator

Thanks for filing and providing LHRs @dkarzon! I can reproduce and know what the problem is, we'll try to get the fix out in the 0.8.0 release this week 👍

@patrickhulce patrickhulce added the bug Something isn't working label Jun 2, 2021
@patrickhulce patrickhulce self-assigned this Jun 2, 2021
@patrickhulce patrickhulce added the P1 label Jun 2, 2021
@dkarzon
Copy link
Author

dkarzon commented Jun 2, 2021

@patrickhulce Awesome thanks!

@dkarzon
Copy link
Author

dkarzon commented Jun 4, 2021

@patrickhulce I have deployed v0.8.0 and can confirm this is now fixed, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P1
Projects
None yet
Development

No branches or pull requests

2 participants