feat(cli): add --puppeteer-script flag to collect #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
approved these changes
Nov 26, 2019
| }; | ||
| ``` | ||
|
|
||
| Lighthouse CI will then use this browser that the script sets up when running Lighthouse. Note that if you store your credentials in `localStorage` or anything other than a cookie you might want to pair this option with `--settings.disableStorageReset` to force Lighthouse to keep the cache state. |
There was a problem hiding this comment.
Link to our auth docs too?
There was a problem hiding this comment.
oh, it's linked in troubleshooting.
| @@ -1,8 +1,7 @@ | |||
| #!/bin/bash | |||
|
|
|||
| CURRENT_VERSION=$(node -e "console.log(require('./package.json').dependencies['@lhci/server'])") | |||
| # NEXT_VERSION=$(yarn info @lhci/server | grep 'latest:' -A 1 | tail -n 1 | grep -o "'.*'" | sed s/\'//g) | |||
| NEXT_VERSION=0.3.3 | |||
| NEXT_VERSION=$(yarn info @lhci/server | grep 'latest:' -A 1 | tail -n 1 | grep -o "'.*'" | sed s/\'//g) | |||
There was a problem hiding this comment.
woah. maybe do a call to node like the line above? this is inscrutable :)
There was a problem hiding this comment.
doing it all in node would be at least a dozen lines though :)
docs/cli.md
Outdated
| ```js | ||
| /** | ||
| * @param {puppeteer.Browser} browser | ||
| * @param {{url: string, options: LHCI.CollectOptions}} context |
There was a problem hiding this comment.
I don't think this type is defined anywhere. is it {url:string, options: LHCI.Options}?
There was a problem hiding this comment.
yeah it's not it was meant to just be user friendly "here are the collect options" but i'll use the real one :)
patrickhulce
force-pushed
the
puppeteer_script
branch
from
8f056b3
to
9684772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #89
Usage looks like:
Example
login-with-puppeteer.js