Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim down Dockerfile #332

Merged
merged 1 commit into from May 28, 2020
Merged

Trim down Dockerfile #332

merged 1 commit into from May 28, 2020

Conversation

mre
Copy link
Contributor

@mre mre commented May 28, 2020

We noticed that the image size could be greatly reduced by using
a smaller base image. This migrates the base image to node:12-buster-slim,
which provides the same functionality but shrinks the image size from
1.5GB to 720MB.
Also, the apt-cache gets cleaned up after package installation to avoid keeping
it in a layer of the Docker image.

This also updates the image to the latest Node version 12.

See also #331 for the server image.

We noticed that the image size could be greatly reduced by using
a smaller base image. This migrates the base image to node:12-buster-slim,
which provides the same functionality but shrinks the image size from
1.5GB to 720MB.
Also, the apt-cache gets cleaned up after package installation to avoid keeping
it in a layer of the Docker image.

This also updates the image to the latest Node version 12.
@patrickhulce patrickhulce merged commit 017dd27 into GoogleChrome:master May 28, 2020
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @mre!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants