Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add commitedAt and ancestorCommittedAt #35

Merged
merged 2 commits into from Oct 30, 2019
Merged

Conversation

paulirish
Copy link
Member

No description provided.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's gonna have to be threaded through the API at each layer :)

would you like some pointers or shall I takeover the PR?

@@ -72,7 +72,7 @@ function getCurrentHash() {
if (envVars.TRAVIS_PULL_REQUEST_SHA) return envVars.TRAVIS_PULL_REQUEST_SHA;
if (envVars.TRAVIS_COMMIT) return envVars.TRAVIS_COMMIT;

const result = childProcess.spawnSync('git', ['rev-list', '--no-merges', '-n', '1', 'HEAD'], {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this impact things or just readability preference?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw i find the new change to be more readable. one option per array entry is good

packages/cli/src/upload/upload.js Outdated Show resolved Hide resolved
@paulirish
Copy link
Member Author

would you like some pointers or shall I takeover the PR?

please do take it over :)

@patrickhulce patrickhulce mentioned this pull request Oct 29, 2019
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@patrickhulce
Copy link
Collaborator

@googlebot I consent

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@patrickhulce patrickhulce changed the title Also gather commit time during upload feat: add commitedAt and ancestorCommittedAt Oct 30, 2019
@patrickhulce patrickhulce merged commit 61b1210 into master Oct 30, 2019
@patrickhulce patrickhulce deleted the committedat branch October 30, 2019 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants