Fix #500 by using uuid to generate the random filename

[PJHRobles]

Fix #500 by using a more robust random filename generation

[patrickhulce]

thanks very much @PJHRobles this is great! elegant, simple solution 👍

would you mind updating the other dependency in LHCI to match this version requirement? I believe its in the server package.json

rerunning yarn to consolidate would be much appreciated too.

[PJHRobles]

Not sure what happened on the mac tests, STDOUT and STDERR doesn't show anything.

FAIL packages/cli/test/upload.test.js (9.152s)
  ● Lighthouse CI upload CLI › should upload for a build

    Server failed to start
    STDOUT: 
    STDERR:

      107 |     await waitForCondition(() => stdout.includes('listening'), 'Server failed to start');
      108 |   } catch (err) {
    > 109 |     throw new Error(`${err.message}\nSTDOUT: ${stdout}\nSTDERR: ${stderr}`);
          |           ^
      110 |   }
      111 | 
      112 |   const port = stdout.match(/port (\d+)/)[1];

Are these perhaps flaky tests?

[patrickhulce]

thanks @PJHRobles it's possible it's just a flake, I kicked off a restart.

Looks like the @types/uuid package version and the yarn.lock didn't get updated with the server change, but LGTM other than that! :)

[patrickhulce]

thanks @PJHRobles!