Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DRONE_BRANCH to env #505

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

mlnchk
Copy link
Contributor

@mlnchk mlnchk commented Dec 9, 2020

No description provided.

@google-cla
Copy link

google-cla bot commented Dec 9, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mlnchk
Copy link
Contributor Author

mlnchk commented Dec 9, 2020

@googlebot I signed it!

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks very much @mlnchk! shall we add the other DRONE_* environment variables?

DRONE_COMMIT_SHA
DRONE_REPO

in particular, bummer that there's no build URL variable

@mlnchk
Copy link
Contributor Author

mlnchk commented Dec 9, 2020

@patrickhulce commit SHA already works (don't know why), and where to use REPO I have not found. But just in case, I'll add them, thanks :)

@mlnchk
Copy link
Contributor Author

mlnchk commented Dec 9, 2020

build url does not exist because Drone is a self-hosted solution I think :(

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlnchk !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants