-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(server) add ability to configure multiple cron tasks and specify which branches should be excluded or included during deletion. #541
Conversation
… which branches should be excluded or included during deletion.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the contribution @MrFlashAccount! I think this is great 👍
cronConfig.forEach((config, index) => { | ||
if (!config.schedule || !config.maxAgeInDays) { | ||
throw new Error( | ||
`Can't configure schedule because you didn't specify 'schedule' field or 'maxAgeInDays' field in item with index: ${index + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there a middle ground between my suggestion and what you have here? :)
I don't feel very strongly about my text, but definitely the context for deleteOldBuilds
and using index
instead of index + 1
is important IMO.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
friendly ping, I'd love to get this merged for the imminent release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I got what you mean. I didn't think about that 👍 replaced index + 1
with index
@patrickhulce Maybe it's better to squash all these three commits? What do think? |
I squashed on merge, thanks again @MrFlashAccount! :) |
Sometimes it would be extremely helpful to have some additional configuration options to describe logic, like:
I want to keep master builds for a year and all other branches for a short period of time