Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server) add ability to configure multiple cron tasks and specify which branches should be excluded or included during deletion. #541

Merged

Conversation

MrFlashAccount
Copy link
Contributor

@MrFlashAccount MrFlashAccount commented Jan 29, 2021

Sometimes it would be extremely helpful to have some additional configuration options to describe logic, like:
I want to keep master builds for a year and all other branches for a short period of time

… which branches should be excluded or included during deletion.
@google-cla
Copy link

google-cla bot commented Jan 29, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@MrFlashAccount
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution @MrFlashAccount! I think this is great 👍

docs/configuration.md Outdated Show resolved Hide resolved
packages/server/src/cron/delete-old-builds.js Outdated Show resolved Hide resolved
cronConfig.forEach((config, index) => {
if (!config.schedule || !config.maxAgeInDays) {
throw new Error(
`Can't configure schedule because you didn't specify 'schedule' field or 'maxAgeInDays' field in item with index: ${index +
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a middle ground between my suggestion and what you have here? :)

I don't feel very strongly about my text, but definitely the context for deleteOldBuilds and using index instead of index + 1 is important IMO.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

friendly ping, I'd love to get this merged for the imminent release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I got what you mean. I didn't think about that 👍 replaced index + 1 with index

@MrFlashAccount
Copy link
Contributor Author

@patrickhulce Maybe it's better to squash all these three commits? What do think?

@patrickhulce patrickhulce merged commit 0638f08 into GoogleChrome:master Feb 2, 2021
@patrickhulce
Copy link
Collaborator

I squashed on merge, thanks again @MrFlashAccount! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants