Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CircleCI config example #721

Merged
merged 1 commit into from
Jul 18, 2022

Conversation

charpeni
Copy link
Contributor

@charpeni charpeni commented Nov 5, 2021

CircleCI deprecated legacy images circleci/* and they won't be supported anymore on December 31, 2021.

Updating this to use cimg/node instead as well as the circleci/browser-tools orb to install Chrome.

Copy link

@adamdmharvey adamdmharvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! Thanks

@arthurboss
Copy link

CircleCI deprecated legacy images circleci/* and they won't be supported anymore on December 31, 2021.

Updating this to use cimg/node instead as well as the circleci/browser-tools orb to install Chrome.

Was about to create the same PR. Our company just faced the issue on ci in which we were missing the circleci/browser-tools orb and lighthouse wouldn't find Chrome's installation and fail, hence I landed here.

@connorjclark connorjclark merged commit d41928d into GoogleChrome:main Jul 18, 2022
@connorjclark
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants