chore(dep): upgrade to puppeteer 13.1.2

[connorjclark]

No description provided.

[connorjclark]

Screenshots used during testing can be 1+ MB, which trips up jest-image-snapshot running the diffing in a child process. The buffer size it uses is node's default of ~200KB. runDiffImageToSnapshot is what throws in node_modules/@storybook/addon-storyshots-puppeteer/node_modules/jest-image-snapshot/src/diff-snapshot.js.

Workaround is to use runInProcess: true. Except... although we use that package directly and can configure runInProcess: true, storybook also uses it... luckily it provides a way to configure the options to jest-image-snapshot (getMatchOptions)

ref americanexpress/jest-image-snapshot#210

[connorjclark]

FAIL packages/cli/test/autorun-github.test.js (51.372s)
  ● Lighthouse CI autorun CLI with GitHub status check › should submit status check to GitHub

    expect(received).toMatchInlineSnapshot(snapshot)

    Snapshot name: `Lighthouse CI autorun CLI with GitHub status check should submit status check to GitHub 1`

    - Snapshot  - 1
    + Received  + 1

    @@ -16,11 +16,11 @@


      Uploading median LHR of http://localhost:XXXX/bad.html...success!
      Open the report at storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/XXXX-XXXX.report.html
      Uploading median LHR of http://localhost:XXXX/good.html...success!
    - Open the report at storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/XXXX-XXXX.report.html
    + Open the report at storage.googleapis.com/lighthouse-infrastructure.appspot.com/reports/XXXX-113.report.html
      GitHub token found, attempting to set status...
      GitHub accepted "failure" status for "lhci/url/bad.html".
      GitHub accepted "success" status for "lhci/url/good.html".

      ↵

      70 |     );
      71 | 
    > 72 |     expect(stdout).toMatchInlineSnapshot(`
         |                    ^
      73 |       "✅  .lighthouseci/ directory writable
      74 |       ✅  Configuration file found
      75 |       ✅  Chrome installation found

      at Object.<anonymous> (packages/cli/test/autorun-github.test.js:72:20)

 › 1 snapshot failed.

[connorjclark]

seems storybook (but only on mac?? these tests only run on mac, filtered in packages/server/test/ui/storybook.test.jsx) is not including packages/server/src/ui/routes/build-view/build-hash-selector.css / other css files...

[connorjclark]

newest chrome resulted in tons of minute text rendering diffs. can't even distinguish them myself but apparently the pixels are different. hence, updating tons of snapshots.

[connorjclark]

seems we should just always wait.

[connorjclark]

RE: #740 (comment)

Not sure why, but with the newest storybook this isn't an issue anymore.

[paulirish]

Workaround is to use runInProcess: true

looks you managed to drop this after the storybook upgrades? that's good news.

[paulirish]

i think these lines can also be removed now (but not 100% sure)

[connorjclark]

No, this is the only way that storybook can have these fonts. The only other place they are added is to the app entry point, which storybook does not use.

[paulirish]

Oh gotcha