fix standalone viewer build via build-app adjustments #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| path.relative(outdir, stylesheet) : | ||
| `/app/${path.relative(outdir, stylesheet)}`; | ||
|
|
||
| const htmls = Object.keys(result.metafile.outputs).filter(o => o.endsWith('.html')); |
There was a problem hiding this comment.
nice job untangling that mess
connorjclark
approved these changes
Apr 30, 2022
|
@connorjclark thx. these CI tests are just so flaky we give it a few attempts and then just merge anyway? |
|
i deployed https://googlechrome.github.io/lighthouse-ci/viewer/ and its lookin good |
This was referenced Nov 27, 2023
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://googlechrome.github.io/lighthouse-ci/viewer/ is busted
fixes #767
but if you build locally and run your server from inside /packages/viewer/dist its all good. the problem is some root-absolute urls... eg
<script src="/script-needed-from-origin-root.js">anyhow. This appears to be the sleekest solution that keeps both viewer and the server app looking good with no broken references.
i found a lot of weird behavior regarding
@chialab/esbuild-plugin-html'andentryNames,assetNamesandchunkNames. really weird. filed this one.but.. ultimately this new usage of that module feels like an improvement over the current status quo.
some development notes
of course the root problem is plenty of 404s.
this is the primary cmd i used to iterate ..