Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): add static dir file discovery depth flag #940

Merged
merged 6 commits into from
Dec 14, 2023

Conversation

DanielSwarup
Copy link
Contributor

  • Added the flag --staticDirFileDiscoveryDepth which enables the user to set the depth of search for index.html files on a static site folder.

Reason For this feature:
When I ran lhci autorun on my static site folder which has deeper folders with index.html it did not recognise them after a depth of 2 folders. This is because LHCI currently hard caps it at a depth of 2. I hope the example in the docs changed file explains it.

(This is my first open-source contribution ever. Thank you for this amazing repo!)

@connorjclark
Copy link
Collaborator

Thanks!

I'm not sure why we have this limit in the first place ... but if we must have it, making it configurable is cool.

@DanielSwarup
Copy link
Contributor Author

Thanks for fixing the linting error! I'll take a look at this test error and push asap.

@connorjclark
Copy link
Collaborator

You should just need to run yarn test:unit -u to update the snapshot tests.

@DanielSwarup
Copy link
Contributor Author

Weirdly enough I've got a bunch of snapshots failing cause chromium is acting up. Could you please update the snapshot? Apologies and thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants