New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

General Discussion #3

Open
housseindjirdeh opened this Issue Jan 16, 2019 · 8 comments

Comments

Projects
None yet
6 participants
@housseindjirdeh
Copy link
Collaborator

housseindjirdeh commented Jan 16, 2019

Opening this issue to have a place where people can leave general suggestions 馃挰.

Some preliminary thoughts to kick things off:

  • Which platforms should we support?
    • After WordPress, we can continue to target other CMS platforms (like Drupal) as well as explore how to include suggestions for JavaScript frameworks (Angular, React, etc...). Anything else?
  • Should we show a toggle to switch between the original Lighthouse report and an updated one with platform-specific strings included? Or should we always surface platform-specific audit messages if a tool is detected on the webpage?

Note: For details on how platform packs will be integrated into core, take a look at the RFC.

@tpiros

This comment has been minimized.

Copy link

tpiros commented Feb 1, 2019

Not a platform/framework per se but would love to see more detailed report about images (or even media) in general.

@docluv

This comment has been minimized.

Copy link

docluv commented Feb 2, 2019

This looks like you are just adding secondary messages based on the platform right now. Not really adding tests at the moment.
Are you planning on adding additional tests/rules for a CMS?
Plus how do you plan on actually auditing server-side code in a platform like WordPress?

Since I use my own platform, can I use this as a model to create my own customized report or an I better off just running it using a node module and then rendering the JSON against my own template. Seems like the same thing you are going right now.

@haassie

This comment has been minimized.

Copy link

haassie commented Feb 3, 2019

I think the opensource CMS TYPO3 might be an interesting next platform. It is already the cms with the highest density of fast FCP as you can see on https://discuss.httparchive.org/t/cms-performance/1468. Besides that the CMS and the community is really having performance as one of the most important topics. So I will definitely go for TYPO3 as one of the next platforms!

@housseindjirdeh

This comment has been minimized.

Copy link
Collaborator Author

housseindjirdeh commented Feb 5, 2019

@docluv Yep, that is correct. We're only planning to add secondary messages for already existing audits to make them more platform-specific. We're not planning to add any extra audits for any tool.

We don't plan to do anything fancy to audit server-side code. We're planning to rely on audits that are already available and flag common issues that folks who use WordPress are most likely experiencing.

If you wanted to set up a report of your own for a specific tool, you might just have to dive into the audit files and include additional messages yourself. You can then boot up the report with Lighthouse Viewer like I did with the first prototype. Once the feature is fully developed however, we may have a better way to fork and build your own version.

@housseindjirdeh

This comment has been minimized.

Copy link
Collaborator Author

housseindjirdeh commented Feb 5, 2019

@haassie I created a separate issue (#7) to list down different tools we can work towards supporting :)

@ericerway

This comment has been minimized.

Copy link

ericerway commented Feb 5, 2019

Nice work! Would love to see this for Magento after Wordpress. We're doing some great things around PWA as a commerce platform with our community. /cc @zetlen

@ezekielchentnik

This comment has been minimized.

Copy link

ezekielchentnik commented Feb 6, 2019

Not framework specific but would love to see more details and reporting for WebGL specific stuff; three.js could also be a framework to focus on.

@housseindjirdeh

This comment has been minimized.

Copy link
Collaborator Author

housseindjirdeh commented Feb 7, 2019

@ericerway We've already been chatting about supporting Magento :) We'll most definitely keep you in the loop when we begin rolling things out for more than just WordPress.

CC @rowan-m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment