fix test bitrot

GoogleChrome · May 4, 2023 · 046bae7 · 046bae7
1 parent 5e8293e
commit 046bae7
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 4 deletions.
diff --git a/core/legacy/config/config.js b/core/legacy/config/config.js
@@ -205,7 +205,7 @@ class LegacyResolvedConfig {
   }
 
   /**
-   * @deprecated `Config.fromJson` should be used instead.
+   * @deprecated `LegacyResolvedConfig.fromJson` should be used instead.
    * @constructor
    * @param {LH.Config} config
    * @param {{settings: LH.Config.Settings, passes: ?LH.Config.Pass[], audits: ?LH.Config.AuditDefn[]}} opts

diff --git a/core/test/gather/driver/execution-context-test.js b/core/test/gather/driver/execution-context-test.js
@@ -209,6 +209,7 @@ describe('.evaluateAsync', () => {
       .mockResponse('Page.enable')
       .mockResponse('Runtime.enable')
       .mockResponse('Page.getResourceTree', {frameTree: {frame: {id: '1337'}}})
+      .mockResponse('Page.getFrameTree', {frameTree: {frame: {id: '1337'}}})
       .mockResponse('Page.createIsolatedWorld', {executionContextId: 9001})
       .mockResponse('Runtime.evaluate', {exceptionDetails});
 

diff --git a/core/test/lib/asset-saver-test.js b/core/test/lib/asset-saver-test.js
@@ -370,7 +370,9 @@ describe('asset-saver helper', () => {
       // Use an LighthouseError that has an ICU replacement.
       const protocolMethod = 'Page.getFastness';
       const lhError = new LighthouseError(
-        LighthouseError.errors.PROTOCOL_TIMEOUT, {protocolMethod}, new Error('the cause'));
+        LighthouseError.errors.PROTOCOL_TIMEOUT,
+        {protocolMethod},
+        {cause: new Error('the cause')});
 
       const artifacts = {
         traces: {},

diff --git a/core/test/runner-test.js b/core/test/runner-test.js
@@ -610,7 +610,7 @@ describe('Runner', () => {
 
     it('produces an error audit result that prefers cause stack', async () => {
       const errorMessage = 'Audit yourself';
-      const config = await Config.fromJson({
+      const resolvedConfig = await LegacyResolvedConfig.fromJson({
         settings: {
           auditMode: moduleDir + '/fixtures/artifacts/empty-artifacts/',
         },
@@ -629,7 +629,7 @@ describe('Runner', () => {
         ],
       });
 
-      return runGatherAndAudit({}, {config}).then(results => {
+      return runGatherAndAudit({}, {resolvedConfig}).then(results => {
         const auditResult = results.lhr.audits['throwy-audit'];
         assert.strictEqual(auditResult.score, null);
         assert.strictEqual(auditResult.scoreDisplayMode, 'error');