Removes hash fragments from url so serviceworker does a correct offli…

…ne check.

We store the url inside options.url without a fragment so we should do this check without fragment as well.
Fixes PR #1296

lighthouse-core/gather/gatherers/offline.js

@@ -17,6 +17,7 @@
 'use strict';
 
 const Gatherer = require('./gatherer');
+const URL = require('../../lib/url-shim');
 
 class Offline extends Gatherer {
   beforePass(options) {
@@ -25,7 +26,8 @@ class Offline extends Gatherer {
 
   afterPass(options, tracingData) {
     const navigationRecord = tracingData.networkRecords.filter(record => {
-      return record._url === options.url && record._fetchedViaServiceWorker;
+      return cleanHash(new URL(record._url)) === cleanHash(new URL(options.url)) &&
+        record._fetchedViaServiceWorker;
     }).pop(); // Take the last record that matches.
 
     return options.driver.goOnline(options).then(_ => {
@@ -34,4 +36,8 @@ class Offline extends Gatherer {
   }
 }
 
+function cleanHash(url) {
+  return url.href.removeURLFragment();
+}
+
 module.exports = Offline;

lighthouse-core/test/gather/gatherers/offline-test.js

@@ -48,8 +48,25 @@ describe('Offline gatherer', () => {
       url: 'https://ifixit-pwa.appspot.com/',
       driver: mockDriver
     };
-    return offlineGather.afterPass(options, tracingData).then(artifact => {
-      assert.strictEqual(artifact, 200);
-    });
+    const optionsWithFragment = {
+      url: 'https://ifixit-pwa.appspot.com/#/history',
+      driver: mockDriver
+    };
+    const optionsWithQueryString = {
+      url: 'https://ifixit-pwa.appspot.com/?history',
+      driver: mockDriver
+    };
+
+    return Promise.all([
+      offlineGather.afterPass(options, tracingData).then(artifact => {
+        assert.strictEqual(artifact, 200);
+      }),
+      offlineGather.afterPass(optionsWithFragment, tracingData).then(artifact => {
+        assert.strictEqual(artifact, 200);
+      }),
+      offlineGather.afterPass(optionsWithQueryString, tracingData).then(artifact => {
+        assert.strictEqual(artifact, -1);
+      }),
+    ]);
   });
 });