Skip to content

Commit

Permalink
core: bump guidance level of top CWV recommendations (#15695)
Browse files Browse the repository at this point in the history
  • Loading branch information
adrianaixba committed Jan 8, 2024
1 parent d1cf7e1 commit 138eaf0
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion core/audits/bf-cache.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ class BFCache extends Audit {
failureTitle: str_(UIStrings.failureTitle),
description: str_(UIStrings.description),
supportedModes: ['navigation', 'timespan'],
guidanceLevel: 2,
guidanceLevel: 4,
requiredArtifacts: ['BFCacheFailures', 'HostProduct'],
scoreDisplayMode: Audit.SCORING_MODES.BINARY,
};
Expand Down
2 changes: 1 addition & 1 deletion core/audits/prioritize-lcp-image.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class PrioritizeLcpImage extends Audit {
title: str_(UIStrings.title),
description: str_(UIStrings.description),
supportedModes: ['navigation'],
guidanceLevel: 3,
guidanceLevel: 4,
requiredArtifacts: ['traces', 'devtoolsLogs', 'GatherContext', 'URL', 'TraceElements'],
scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
};
Expand Down
2 changes: 1 addition & 1 deletion core/audits/unsized-images.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class UnsizedImages extends Audit {
title: str_(UIStrings.title),
failureTitle: str_(UIStrings.failureTitle),
description: str_(UIStrings.description),
guidanceLevel: 3,
guidanceLevel: 4,
requiredArtifacts: ['ImageElements'],
scoreDisplayMode: Audit.SCORING_MODES.METRIC_SAVINGS,
};
Expand Down
18 changes: 9 additions & 9 deletions core/test/fixtures/user-flows/reports/sample-flow-result.json
Original file line number Diff line number Diff line change
Expand Up @@ -1989,7 +1989,7 @@
}
]
},
"guidanceLevel": 3
"guidanceLevel": 4
},
"valid-source-maps": {
"id": "valid-source-maps",
Expand Down Expand Up @@ -2038,7 +2038,7 @@
"pathLength": 2
}
},
"guidanceLevel": 3
"guidanceLevel": 4
},
"csp-xss": {
"id": "csp-xss",
Expand Down Expand Up @@ -3790,7 +3790,7 @@
"description": "Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://developer.chrome.com/docs/lighthouse/performance/bf-cache/)",
"score": 1,
"scoreDisplayMode": "binary",
"guidanceLevel": 2
"guidanceLevel": 4
}
},
"configSettings": {
Expand Down Expand Up @@ -10099,7 +10099,7 @@
}
]
},
"guidanceLevel": 3
"guidanceLevel": 4
},
"valid-source-maps": {
"id": "valid-source-maps",
Expand Down Expand Up @@ -10957,7 +10957,7 @@
"description": "Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://developer.chrome.com/docs/lighthouse/performance/bf-cache/)",
"score": 1,
"scoreDisplayMode": "binary",
"guidanceLevel": 2
"guidanceLevel": 4
}
},
"configSettings": {
Expand Down Expand Up @@ -13043,7 +13043,7 @@
}
]
},
"guidanceLevel": 3
"guidanceLevel": 4
},
"accesskeys": {
"id": "accesskeys",
Expand Down Expand Up @@ -19942,7 +19942,7 @@
}
]
},
"guidanceLevel": 3
"guidanceLevel": 4
},
"valid-source-maps": {
"id": "valid-source-maps",
Expand Down Expand Up @@ -19991,7 +19991,7 @@
"pathLength": 2
}
},
"guidanceLevel": 3
"guidanceLevel": 4
},
"csp-xss": {
"id": "csp-xss",
Expand Down Expand Up @@ -21907,7 +21907,7 @@
"description": "Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://developer.chrome.com/docs/lighthouse/performance/bf-cache/)",
"score": 1,
"scoreDisplayMode": "binary",
"guidanceLevel": 2
"guidanceLevel": 4
}
},
"configSettings": {
Expand Down
6 changes: 3 additions & 3 deletions core/test/results/sample_v2.json
Original file line number Diff line number Diff line change
Expand Up @@ -2875,7 +2875,7 @@
}
]
},
"guidanceLevel": 3
"guidanceLevel": 4
},
"valid-source-maps": {
"id": "valid-source-maps",
Expand Down Expand Up @@ -2969,7 +2969,7 @@
"pathLength": 4
}
},
"guidanceLevel": 3
"guidanceLevel": 4
},
"csp-xss": {
"id": "csp-xss",
Expand Down Expand Up @@ -5852,7 +5852,7 @@
}
]
},
"guidanceLevel": 2
"guidanceLevel": 4
}
},
"configSettings": {
Expand Down

0 comments on commit 138eaf0

Please sign in to comment.