Skip to content

Commit

Permalink
core(config): reorder categories to match new gauge order (#6848)
Browse files Browse the repository at this point in the history
  • Loading branch information
@exterkamp @paulirish
exterkamp authored and paulirish committed Dec 20, 2018
1 parent 845cd29 commit 1c78994
Show file tree
Hide file tree
Showing 2 changed files with 109 additions and 109 deletions.
56 changes: 28 additions & 28 deletions lighthouse-core/config/default-config.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -358,34 +358,6 @@ const defaultConfig = {
{id: 'font-display', weight: 0, group: 'diagnostics'},
],
},
'pwa': {
title: 'Progressive Web App',
description: 'These checks validate the aspects of a Progressive Web App. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist).',
manualDescription: 'These checks are required by the baseline ' +
'[PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are ' +
'not automatically checked by Lighthouse. They do not affect your score but it\'s important that you verify them manually.',
auditRefs: [
// Fast and Reliable
{id: 'load-fast-enough-for-pwa', weight: 7, group: 'pwa-fast-reliable'},
{id: 'works-offline', weight: 5, group: 'pwa-fast-reliable'},
{id: 'offline-start-url', weight: 1, group: 'pwa-fast-reliable'},
// Installable
{id: 'is-on-https', weight: 2, group: 'pwa-installable'},
{id: 'service-worker', weight: 1, group: 'pwa-installable'},
{id: 'installable-manifest', weight: 2, group: 'pwa-installable'},
// PWA Optimized
{id: 'redirects-http', weight: 2, group: 'pwa-optimized'},
{id: 'splash-screen', weight: 1, group: 'pwa-optimized'},
{id: 'themed-omnibox', weight: 1, group: 'pwa-optimized'},
{id: 'content-width', weight: 1, group: 'pwa-optimized'},
{id: 'viewport', weight: 2, group: 'pwa-optimized'},
{id: 'without-javascript', weight: 1, group: 'pwa-optimized'},
// Manual audits
{id: 'pwa-cross-browser', weight: 0},
{id: 'pwa-page-transitions', weight: 0},
{id: 'pwa-each-page-has-url', weight: 0},
],
},
'accessibility': {
title: 'Accessibility',
description: 'These checks highlight opportunities to [improve the accessibility of your web app](https://developers.google.com/web/fundamentals/accessibility). Only a subset of accessibility issues can be automatically detected so manual testing is also encouraged.',
Expand Down Expand Up @@ -483,6 +455,34 @@ const defaultConfig = {
{id: 'structured-data', weight: 0},
],
},
'pwa': {
title: 'Progressive Web App',
description: 'These checks validate the aspects of a Progressive Web App. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist).',
manualDescription: 'These checks are required by the baseline ' +
'[PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are ' +
'not automatically checked by Lighthouse. They do not affect your score but it\'s important that you verify them manually.',
auditRefs: [
// Fast and Reliable
{id: 'load-fast-enough-for-pwa', weight: 7, group: 'pwa-fast-reliable'},
{id: 'works-offline', weight: 5, group: 'pwa-fast-reliable'},
{id: 'offline-start-url', weight: 1, group: 'pwa-fast-reliable'},
// Installable
{id: 'is-on-https', weight: 2, group: 'pwa-installable'},
{id: 'service-worker', weight: 1, group: 'pwa-installable'},
{id: 'installable-manifest', weight: 2, group: 'pwa-installable'},
// PWA Optimized
{id: 'redirects-http', weight: 2, group: 'pwa-optimized'},
{id: 'splash-screen', weight: 1, group: 'pwa-optimized'},
{id: 'themed-omnibox', weight: 1, group: 'pwa-optimized'},
{id: 'content-width', weight: 1, group: 'pwa-optimized'},
{id: 'viewport', weight: 2, group: 'pwa-optimized'},
{id: 'without-javascript', weight: 1, group: 'pwa-optimized'},
// Manual audits
{id: 'pwa-cross-browser', weight: 0},
{id: 'pwa-page-transitions', weight: 0},
{id: 'pwa-each-page-has-url', weight: 0},
],
},
},
};

Expand Down
162 changes: 81 additions & 81 deletions lighthouse-core/test/results/sample_v2.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2918,87 +2918,6 @@
"id": "performance",
"score": 0.69
},
"pwa": {
"title": "Progressive Web App",
"description": "These checks validate the aspects of a Progressive Web App. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist).",
"manualDescription": "These checks are required by the baseline [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are not automatically checked by Lighthouse. They do not affect your score but it's important that you verify them manually.",
"auditRefs": [
{
"id": "load-fast-enough-for-pwa",
"weight": 7,
"group": "pwa-fast-reliable"
},
{
"id": "works-offline",
"weight": 5,
"group": "pwa-fast-reliable"
},
{
"id": "offline-start-url",
"weight": 1,
"group": "pwa-fast-reliable"
},
{
"id": "is-on-https",
"weight": 2,
"group": "pwa-installable"
},
{
"id": "service-worker",
"weight": 1,
"group": "pwa-installable"
},
{
"id": "installable-manifest",
"weight": 2,
"group": "pwa-installable"
},
{
"id": "redirects-http",
"weight": 2,
"group": "pwa-optimized"
},
{
"id": "splash-screen",
"weight": 1,
"group": "pwa-optimized"
},
{
"id": "themed-omnibox",
"weight": 1,
"group": "pwa-optimized"
},
{
"id": "content-width",
"weight": 1,
"group": "pwa-optimized"
},
{
"id": "viewport",
"weight": 2,
"group": "pwa-optimized"
},
{
"id": "without-javascript",
"weight": 1,
"group": "pwa-optimized"
},
{
"id": "pwa-cross-browser",
"weight": 0
},
{
"id": "pwa-page-transitions",
"weight": 0
},
{
"id": "pwa-each-page-has-url",
"weight": 0
}
],
"id": "pwa",
"score": 0.42
},
"accessibility": {
"title": "Accessibility",
"description": "These checks highlight opportunities to [improve the accessibility of your web app](https://developers.google.com/web/fundamentals/accessibility). Only a subset of accessibility issues can be automatically detected so manual testing is also encouraged.",
Expand Down Expand Up @@ -3365,6 +3284,87 @@
],
"id": "seo",
"score": null
},
"pwa": {
"title": "Progressive Web App",
"description": "These checks validate the aspects of a Progressive Web App. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist).",
"manualDescription": "These checks are required by the baseline [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are not automatically checked by Lighthouse. They do not affect your score but it's important that you verify them manually.",
"auditRefs": [
{
"id": "load-fast-enough-for-pwa",
"weight": 7,
"group": "pwa-fast-reliable"
},
{
"id": "works-offline",
"weight": 5,
"group": "pwa-fast-reliable"
},
{
"id": "offline-start-url",
"weight": 1,
"group": "pwa-fast-reliable"
},
{
"id": "is-on-https",
"weight": 2,
"group": "pwa-installable"
},
{
"id": "service-worker",
"weight": 1,
"group": "pwa-installable"
},
{
"id": "installable-manifest",
"weight": 2,
"group": "pwa-installable"
},
{
"id": "redirects-http",
"weight": 2,
"group": "pwa-optimized"
},
{
"id": "splash-screen",
"weight": 1,
"group": "pwa-optimized"
},
{
"id": "themed-omnibox",
"weight": 1,
"group": "pwa-optimized"
},
{
"id": "content-width",
"weight": 1,
"group": "pwa-optimized"
},
{
"id": "viewport",
"weight": 2,
"group": "pwa-optimized"
},
{
"id": "without-javascript",
"weight": 1,
"group": "pwa-optimized"
},
{
"id": "pwa-cross-browser",
"weight": 0
},
{
"id": "pwa-page-transitions",
"weight": 0
},
{
"id": "pwa-each-page-has-url",
"weight": 0
}
],
"id": "pwa",
"score": 0.42
}
},
"categoryGroups": {
Expand Down

0 comments on commit 1c78994

Please sign in to comment.