Return if href startsWith mailto

GoogleChrome · Oct 11, 2020 · 219b93b · 219b93b
1 parent 7c14f1b
commit 219b93b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/lighthouse-core/audits/seo/crawlable-anchors.js b/lighthouse-core/audits/seo/crawlable-anchors.js
@@ -53,6 +53,7 @@ class CrawlableAnchors extends Audit {
       role = role.trim();
 
       if (role.length > 0) return;
+      if (rawHref.startsWith('mailto:')) return;
 
       const windowLocationRegExp = /window\.location=/;
       const windowOpenRegExp = /window\.open\(/;

diff --git a/lighthouse-core/test/audits/seo/crawlable-anchors-test.js b/lighthouse-core/test/audits/seo/crawlable-anchors-test.js
@@ -153,7 +153,7 @@ describe('SEO: Crawlable anchors audit', () => {
     }
   });
 
-  it('handles window.open in an onclick attribute and mailto: in href attribute', () => {
+  it('handles window.open in an onclick attribute and mailto: in a href attribute', () => {
     assert.equal(
         runAudit({rawHref: 'mailto:name@example.com', onclick: 'window.open()'}),
         1,