Skip to content

Commit

Permalink
fix: deprecated node usage in actions/checkout@v3
Browse files Browse the repository at this point in the history
  • Loading branch information
hamirmahal committed May 28, 2024
1 parent 8d1d78b commit 24f6ce7
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
# https://github.com/actions/runner/issues/438
steps:
- name: git clone
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
fetch-depth: 100
- run: bash core/scripts/github-actions-commit-range.sh
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/cron-weekly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,15 @@ jobs:
check-links:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: gaurav-nelson/github-action-markdown-link-check@a996638015fbc9ef96beef1a41bbad7df8e06154
# checks all markdown files from /docs including all subfolders
with:
use-quiet-mode: 'yes'
use-verbose-mode: 'yes'
config-file: '.github/workflows/markdown.links.config.json'
folder-path: 'docs/'
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: gaurav-nelson/github-action-markdown-link-check@a996638015fbc9ef96beef1a41bbad7df8e06154
# checks all markdown files from root but ignores subfolders
with:
Expand All @@ -30,7 +30,7 @@ jobs:

steps:
- name: git clone
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/devtools.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
run: echo "$DEPOT_TOOLS_PATH" >> $GITHUB_PATH

- name: git clone
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: lighthouse

Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:

steps:
- name: git clone
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: lighthouse

Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:

steps:
- name: git clone
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
path: lighthouse

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/package-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

steps:
- name: git clone
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node.js 18.x
uses: actions/setup-node@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
outputs:
should_run: ${{ steps.should_run.outputs.should_run }}
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: print latest_commit
run: echo ${{ github.sha }}

Expand All @@ -28,7 +28,7 @@ jobs:
(github.repository == 'GoogleChrome/lighthouse' && ${{ needs.check_date.outputs.should_run != 'false' }})
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- uses: actions/setup-node@v3
with:
node-version: 18.x
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:

steps:
- name: git clone
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Depth of at least 2 for codecov coverage diffs. See https://github.com/GoogleChrome/lighthouse/pull/12079
fetch-depth: 2
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:

steps:
- name: git clone
uses: actions/checkout@v3
uses: actions/checkout@v4

# Use Node 18 here earlier than everywhere else, see https://github.com/GoogleChrome/lighthouse/issues/15160#issuecomment-1589913408
- name: Use Node.js 18.x
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:

steps:
- name: git clone
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node.js 18.x
uses: actions/setup-node@v3
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:

steps:
- name: git clone
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
# Depth of at least 2 for codecov coverage diffs. See https://github.com/GoogleChrome/lighthouse/pull/12079
fetch-depth: 2
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:

steps:
- name: git clone
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Use Node.js 18.x
uses: actions/setup-node@v3
Expand Down

0 comments on commit 24f6ce7

Please sign in to comment.