Skip to content

Commit

Permalink
update eslint version for extension to match core
Browse files Browse the repository at this point in the history
make extension linting failures fail build as well
  • Loading branch information
brendankenny committed Dec 14, 2016
1 parent 279965c commit 2fbceda
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
3 changes: 2 additions & 1 deletion lighthouse-extension/gulpfile.js
Expand Up @@ -50,7 +50,8 @@ gulp.task('lint', () => {
'gulpfile.js'
])
.pipe(eslint())
.pipe(eslint.format());
.pipe(eslint.format())
.pipe(eslint.failAfterError());
});

gulp.task('images', () => {
Expand Down
3 changes: 1 addition & 2 deletions lighthouse-extension/package.json
Expand Up @@ -12,11 +12,10 @@
"brfs": "^1.4.3",
"browserify": "^13.0.0",
"del": "^2.2.0",
"eslint-config-xo": "^0.10.1",
"gulp": "^3.9.1",
"gulp-chrome-manifest": "0.0.13",
"gulp-debug": "^2.1.2",
"gulp-eslint": "^2.0.0",
"gulp-eslint": "^3.0.1",
"gulp-livereload": "^3.8.1",
"gulp-tap": "^0.1.3",
"gulp-util": "^3.0.7",
Expand Down

0 comments on commit 2fbceda

Please sign in to comment.