core(network-requests): include starting timestamp as debug data (#14253

)
GoogleChrome · Aug 2, 2022 · 3cfa258 · 3cfa258
1 parent bbfeaf1
commit 3cfa258
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 4 deletions.
diff --git a/lighthouse-core/audits/network-requests.js b/lighthouse-core/audits/network-requests.js
@@ -110,6 +110,14 @@ class NetworkRequests extends Audit {
 
     const tableDetails = Audit.makeTableDetails(headings, results);
 
+    // Include starting timestamp to allow syncing requests with navStart/metric timestamps.
+    const networkStartTimeTs = Number.isFinite(earliestStartTime) ?
+        earliestStartTime * 1_000_000 : undefined;
+    tableDetails.debugData = {
+      type: 'debugdata',
+      networkStartTimeTs,
+    };
+
     return {
       score: 1,
       details: tableDetails,

diff --git a/lighthouse-core/test/audits/network-requests-test.js b/lighthouse-core/test/audits/network-requests-test.js
@@ -57,6 +57,11 @@ describe('Network requests audit', () => {
       mimeType: 'application/javascript',
       resourceType: 'Script',
     });
+
+    expect(output.details.debugData).toStrictEqual({
+      type: 'debugdata',
+      networkStartTimeTs: 360725781425,
+    });
   });
 
   it('should handle times correctly', async () => {

diff --git a/lighthouse-core/test/fixtures/fraggle-rock/reports/sample-flow-result.json b/lighthouse-core/test/fixtures/fraggle-rock/reports/sample-flow-result.json
@@ -1057,7 +1057,11 @@
                   "resourceType": "Other",
                   "experimentalFromMainFrame": true
                 }
-              ]
+              ],
+              "debugData": {
+                "type": "debugdata",
+                "networkStartTimeTs": 28621648277
+              }
             }
           },
           "network-rtt": {
@@ -8377,7 +8381,11 @@
                   "mimeType": "image/jpeg",
                   "resourceType": "Image"
                 }
-              ]
+              ],
+              "debugData": {
+                "type": "debugdata",
+                "networkStartTimeTs": 28632353955
+              }
             }
           },
           "network-rtt": {
@@ -16906,7 +16914,11 @@
                   "resourceType": "Script",
                   "experimentalFromMainFrame": true
                 }
-              ]
+              ],
+              "debugData": {
+                "type": "debugdata",
+                "networkStartTimeTs": 28653584680
+              }
             }
           },
           "network-rtt": {

diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json
@@ -1638,7 +1638,11 @@
             "resourceType": "Other",
             "experimentalFromMainFrame": true
           }
-        ]
+        ],
+        "debugData": {
+          "type": "debugdata",
+          "networkStartTimeTs": 8696703416
+        }
       }
     },
     "network-rtt": {