Fix show omitted lines indicator at end in expanded mode

GoogleChrome · Jan 20, 2019 · 3f7e50d · 3f7e50d
1 parent 0f79fdc
commit 3f7e50d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lighthouse-core/report/html/renderer/code-snippet-renderer.js b/lighthouse-core/report/html/renderer/code-snippet-renderer.js
@@ -165,7 +165,7 @@ class CodeSnippetRenderer {
     }
     if (!lastLineIsVisible) {
       snippet.append(CodeSnippetRenderer.renderOmittedLines(dom, tmpl,
-        LineVisibility.WHEN_COLLAPSED
+        LineVisibility.WHEN_EXPANDED
       ));
     }
 

diff --git a/lighthouse-core/test/report/html/renderer/code-snippet-renderer-test.js b/lighthouse-core/test/report/html/renderer/code-snippet-renderer-test.js
@@ -105,7 +105,12 @@ describe('DetailsRenderer', () => {
     const visibleLines = el.querySelectorAll(
       '.lh-code-snippet__line--code:not(.lh-code-snippet__show-if-expanded)');
     const lastVisibleLine = visibleLines[visibleLines.length - 1];
+    const omittedLinesIndicators = el.querySelectorAll('.lh-code-snippet__line--empty');
+
     // Shows first 5 visible lines
     assert.equal(lastVisibleLine.textContent.replace(/\s/g, ''), '5E');
+    // "..." after the available lines, but only shows in expanded state
+    assert.equal(omittedLinesIndicators.length, 1);
+    assert.ok(omittedLinesIndicators[0].classList.contains('lh-code-snippet__show-if-expanded'));
   });
 });