Skip to content

Commit

Permalink
tests(smokehouse): run smoketests in parallel (#4748)
Browse files Browse the repository at this point in the history
* Replaced those gnarly `run-test.sh` scripts with a flexible JS-based smoketest runner. Runs each `smokehouse.js` invocation in its own child-process.
* Moved a run of `dbw-expectations` into `offline`, as it was testing the exact same URL, just asserting different aspects out the output.
* `yarn smoke` will run all, but you can do `yarn smoke byte` and `yarn smoke byte ttci` to run individual smokehouse expectations
* Split the PWA smoketests into two files (`pwa` and `pwa2`), as they were some of the slowest smoketests we did.
* `yarn smokehouse` was removed. it's effectively replaced with `yarn smoke pwa && yarn smoke pwa2`
* Restore the `shop.polymer-project.org` smoketest. 
  * Add a workaround for #4898, since it reproduces in this test.
  • Loading branch information
paulirish committed Apr 11, 2018
1 parent ff4f111 commit 419b023
Show file tree
Hide file tree
Showing 19 changed files with 571 additions and 514 deletions.
1 change: 0 additions & 1 deletion .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ test_script:
- yarn unit
- yarn type-check
- yarn smoke
- yarn smokehouse

cache:
#- chrome-win32 -> appveyor.yml,package.json
Expand Down
1 change: 0 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ script:
- yarn type-check
- yarn closure
- yarn smoke
- yarn smokehouse
- yarn test-extension
# _JAVA_OPTIONS is breaking parsing of compiler output. See #3338.
- unset _JAVA_OPTIONS
Expand Down
16 changes: 0 additions & 16 deletions lighthouse-cli/test/smokehouse/a11y/run-tests.sh

This file was deleted.

16 changes: 0 additions & 16 deletions lighthouse-cli/test/smokehouse/byte-efficiency/run-tests.sh

This file was deleted.

41 changes: 0 additions & 41 deletions lighthouse-cli/test/smokehouse/dobetterweb/dbw-expectations.js
Original file line number Diff line number Diff line change
Expand Up @@ -186,46 +186,5 @@ module.exports = [
},
},
},
}, {
initialUrl: 'http://localhost:10200/online-only.html',
url: 'http://localhost:10200/online-only.html',
audits: {
'is-on-https': {
score: 1,
},
'uses-http2': {
score: 0,
},
'external-anchors-use-rel-noopener': {
score: 1,
},
'appcache-manifest': {
score: 1,
},
'geolocation-on-start': {
score: 1,
},
'link-blocking-first-paint': {
score: 1,
},
'no-document-write': {
score: 1,
},
'no-mutation-events': {
score: 1,
},
'no-websql': {
score: 1,
},
'script-blocking-first-paint': {
score: 1,
},
'uses-passive-event-listeners': {
score: 1,
},
'password-inputs-can-be-pasted-into': {
score: 1,
},
},
},
];
17 changes: 0 additions & 17 deletions lighthouse-cli/test/smokehouse/dobetterweb/run-tests.sh

This file was deleted.

5 changes: 5 additions & 0 deletions lighthouse-cli/test/smokehouse/offline-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
module.exports = {
extends: 'lighthouse:default',
settings: {
onlyCategories: [
'best-practices',
],
onlyAudits: [
'is-on-https',
'redirects-http',
Expand All @@ -20,6 +23,8 @@ module.exports = {
'without-javascript',
'user-timings',
'critical-request-chains',
'link-blocking-first-paint',
'script-blocking-first-paint',
'webapp-install-banner',
'splash-screen',
'themed-omnibox',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,39 @@ module.exports = [
'is-on-https': {
score: 1,
},
'uses-http2': {
score: 0,
},
'external-anchors-use-rel-noopener': {
score: 1,
},
'appcache-manifest': {
score: 1,
},
'geolocation-on-start': {
score: 1,
},
'link-blocking-first-paint': {
score: 1,
},
'no-document-write': {
score: 1,
},
'no-mutation-events': {
score: 1,
},
'no-websql': {
score: 1,
},
'script-blocking-first-paint': {
score: 1,
},
'uses-passive-event-listeners': {
score: 1,
},
'password-inputs-can-be-pasted-into': {
score: 1,
},
'redirects-http': {
score: 0,
},
Expand Down
17 changes: 0 additions & 17 deletions lighthouse-cli/test/smokehouse/offline-local/run-tests.sh

This file was deleted.

16 changes: 0 additions & 16 deletions lighthouse-cli/test/smokehouse/perf/run-tests.sh

This file was deleted.

Loading

0 comments on commit 419b023

Please sign in to comment.