replace formatters for helptext.

GoogleChrome · Nov 2, 2016 · 48f44c9 · 48f44c9
1 parent eafaa33
commit 48f44c9
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 85 deletions.
diff --git a/lighthouse-cli/test/fixtures/sample.json b/lighthouse-cli/test/fixtures/sample.json
@@ -163,7 +163,7 @@
             "time": 18.540999999999997
           }
         ],
-        "formatter": "estimatedInputLatency"
+        "formatter": "null"
       },
       "name": "estimated-input-latency",
       "category": "Performance",

diff --git a/lighthouse-core/audits/estimated-input-latency.js b/lighthouse-core/audits/estimated-input-latency.js
@@ -35,6 +35,9 @@ class EstimatedInputLatency extends Audit {
       name: 'estimated-input-latency',
       description: 'Estimated Input Latency',
       optimalValue: SCORING_POINT_OF_DIMINISHING_RETURNS.toLocaleString() + 'ms',
+      helpText: 'Primarily a measure of the main thread\'s activity. ' +
+      'There is a 90% probabililty a user would encounter input latency of this amount or less. ' +
+      '10% of touches can expect additional latency.',
       requiredArtifacts: ['traceContents']
     };
   }
@@ -67,7 +70,7 @@ class EstimatedInputLatency extends Audit {
       displayValue: `${rawValue}ms`,
       extendedInfo: {
         value: latencyPercentiles,
-        formatter: Formatter.SUPPORTED_FORMATS.ESTIMATED_INPUT_LATENCY
+        formatter: Formatter.SUPPORTED_FORMATS.NULL
       }
     });
   }

diff --git a/lighthouse-core/formatters/estimated-input-latency.js b/lighthouse-core/formatters/estimated-input-latency.js
diff --git a/lighthouse-core/formatters/formatter.js b/lighthouse-core/formatters/formatter.js
@@ -41,7 +41,6 @@ class Formatter {
     this._formatters = {
       accessibility: require('./accessibility'),
       criticalRequestChains: require('./critical-request-chains'),
-      estimatedInputLatency: require('./estimated-input-latency'),
       urllist: require('./url-list'),
       null: require('./null-formatter'),
       speedline: require('./speedline-formatter'),

diff --git a/lighthouse-core/formatters/partials/estimated-input-latency.html b/lighthouse-core/formatters/partials/estimated-input-latency.html
diff --git a/lighthouse-core/test/results/sample.json b/lighthouse-core/test/results/sample.json
@@ -145,7 +145,7 @@
             "time": 18.540999999999997
           }
         ],
-        "formatter": "estimatedInputLatency"
+        "formatter": "null"
       },
       "name": "estimated-input-latency",
       "category": "Performance",