reportcontext etc.

GoogleChrome · Nov 10, 2016 · 4adf946 · 4adf946
1 parent e43341e
commit 4adf946
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/lighthouse-core/report/report-generator.js b/lighthouse-core/report/report-generator.js
@@ -222,9 +222,10 @@ class ReportGenerator {
   /**
    * Generates the Lighthouse report HTML.
    * @param {!Object} results Lighthouse results.
+   * @param {!string} reportContext Where the report is going
    * @returns {string} HTML of the report page.
    */
-  generateHTML(results) {
+  generateHTML(results, reportContext) {
     // Ensure the formatter for each extendedInfo is registered.
     Object.keys(results.audits).forEach(audit => {
       // Use value rather than key for audit.
@@ -261,7 +262,7 @@ class ReportGenerator {
       generatedTime: this._formatTime(results.generatedTime),
       lhresults: JSON.stringify(results, null, 2),
       css: this.getReportCSS(),
-      reportContext: 'extension', // devtools, extension, cli
+      reportContext: reportContext || 'extension', // devtools, extension, cli
       script: this.getReportJS(),
       aggregations: results.aggregations,
       auditsByCategory: this._createPWAAuditsByCategory(results.aggregations)

diff --git a/lighthouse-extension/app/src/lighthouse-background.js b/lighthouse-extension/app/src/lighthouse-background.js
@@ -63,7 +63,7 @@ window.runLighthouseInExtension = function(options, requestedAudits) {
   return connection.getCurrentTabURL()
     .then(url => window.runLighthouseForConnection(connection, url, options, requestedAudits))
     .then(results => {
-      const blobURL = window.createReportPageAsBlob(results);
+      const blobURL = window.createReportPageAsBlob(results, 'extension');
       chrome.tabs.create({url: blobURL});
     });
 };
@@ -84,15 +84,16 @@ window.runLighthouseInWorker = function(port, url, options, requestedAudits) {
 
 /**
  * @param {!Object} results Lighthouse results object
+ * @param {!string} reportContext Where the report is going
  * @return {!string} Blob URL of the report (or error page) HTML
  */
-window.createReportPageAsBlob = function(results) {
+window.createReportPageAsBlob = function(results, reportContext) {
   performance.mark('report-start');
 
   const reportGenerator = new ReportGenerator();
   let html;
   try {
-    html = reportGenerator.generateHTML(results);
+    html = reportGenerator.generateHTML(results, reportContext);
   } catch (err) {
     html = reportGenerator.renderException(err, results);
   }