traceviewer doesnt think it runs in a content script.

GoogleChrome · Oct 2, 2016 · 562430c · 562430c
1 parent b60634d
commit 562430c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lighthouse-core/scripts/build-traceviewer-module.js b/lighthouse-core/scripts/build-traceviewer-module.js
@@ -70,6 +70,8 @@ function convertImport(src) {
 
       // node4 compat
       scriptsContent = polyfillNode4Support(dest, scriptsContent);
+      // browser compat
+      scriptsContent = adjustForBrowserCompat(scriptsContent);
 
       writeNewFile(dest, scriptsContent);
 
@@ -133,6 +135,12 @@ function convertImport(src) {
         return transformed;
       }
 
+      function adjustForBrowserCompat(scriptsContent) {
+        return scriptsContent
+            // early exit in tracing/base.ui and avoid currentScript from breaking us.
+            .replace('var THIS_DOC = document.currentScript.ownerDocument;', 'return;');
+      }
+
       function writeNewFile(dest, scriptsContent) {
         dest = dest.replace('./third_party/src/catapult/tracing/tracing/', '');
         dest = path.resolve('./third_party/traceviewer-js/' + dest);

diff --git a/lighthouse-core/third_party/traceviewer-js/ui/base/overlay.js b/lighthouse-core/third_party/traceviewer-js/ui/base/overlay.js
@@ -24,7 +24,7 @@ require("./utils.js");
 global.tr.exportTo('tr.ui.b', function () {
   if (tr.isHeadless) return {};
 
-  var THIS_DOC = document.currentScript.ownerDocument;
+  return;
 
   /**
    * Creates a new overlay element. It will not be visible until shown.