add duplicate test and switch to getDisplayName

GoogleChrome · Jan 27, 2017 · 5cf4646 · 5cf4646
1 parent 025b584
commit 5cf4646
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 4 deletions.
diff --git a/lighthouse-core/audits/dobetterweb/link-blocking-first-paint.js b/lighthouse-core/audits/dobetterweb/link-blocking-first-paint.js
@@ -22,6 +22,7 @@
 'use strict';
 
 const Audit = require('../audit');
+const URL = require('../../lib/url-shim');
 const Formatter = require('../../formatters/formatter');
 
 class LinkBlockingFirstPaintAudit extends Audit {
@@ -65,7 +66,7 @@ class LinkBlockingFirstPaintAudit extends Audit {
       endTime = Math.max(item.endTime, endTime);
 
       return {
-        url: item.tag.url,
+        url: URL.getDisplayName(item.tag.url),
         totalKb: `${Math.round(item.transferSize / 1024)} KB`,
         totalMs: `${Math.round((item.endTime - startTime) * 1000)}ms`
       };

diff --git a/lighthouse-core/test/audits/dobetterweb/link-blocking-first-paint-test.js b/lighthouse-core/test/audits/dobetterweb/link-blocking-first-paint-test.js
@@ -67,7 +67,7 @@ describe('Link Block First Paint audit', () => {
     assert.equal(auditResult.rawValue, false);
     assert.ok(auditResult.displayValue.match('2 resources delayed first paint by 500ms'));
     assert.equal(auditResult.extendedInfo.value.results.length, 2);
-    assert.ok(auditResult.extendedInfo.value.results[0].url.match(linkDetails.href));
+    assert.equal(auditResult.extendedInfo.value.results[0].url, 'css/style.css');
     assert.equal(auditResult.extendedInfo.value.results[0].totalMs, '500ms');
     assert.equal(auditResult.extendedInfo.value.results[1].totalMs, '200ms');
   });

diff --git a/lighthouse-core/test/audits/dobetterweb/script-blocking-first-paint-test.js b/lighthouse-core/test/audits/dobetterweb/script-blocking-first-paint-test.js
@@ -64,7 +64,7 @@ describe('Script Block First Paint audit', () => {
     assert.equal(auditResult.rawValue, false);
     assert.ok(auditResult.displayValue.match('2 resources delayed first paint by 150ms'));
     assert.equal(auditResult.extendedInfo.value.results.length, 2);
-    assert.ok(auditResult.extendedInfo.value.results[0].url.match(scriptDetails.src));
+    assert.equal(auditResult.extendedInfo.value.results[0].url, 'js/app.js');
     assert.equal(auditResult.extendedInfo.value.results[0].totalMs, '150ms');
     assert.equal(auditResult.extendedInfo.value.results[1].totalMs, '50ms');
   });

diff --git a/lighthouse-core/test/gather/gatherers/dobetterweb/tags-blocking-first-paint-test.js b/lighthouse-core/test/gather/gatherers/dobetterweb/tags-blocking-first-paint-test.js
@@ -134,7 +134,7 @@ describe('First paint blocking tags', () => {
     return tagsBlockingFirstPaint.afterPass({
       driver: {
         evaluateAsync() {
-          return Promise.resolve([linkDetails, scriptDetails]);
+          return Promise.resolve([linkDetails, linkDetails, scriptDetails]);
         }
       }
     }, traceData).then(artifact => {