Move perfy stuff into Perf Diagnostics report aggregation.

GoogleChrome · Feb 15, 2017 · 791287f · 791287f
1 parent d1b9110
commit 791287f
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 28 deletions.
diff --git a/lighthouse-core/audits/byte-efficiency/unused-css-rules.js b/lighthouse-core/audits/byte-efficiency/unused-css-rules.js
@@ -29,7 +29,7 @@ class UnusedCSSRules extends Audit {
     return {
       category: 'CSS',
       name: 'unused-css-rules',
-      description: 'Avoids loading unnecessary CSS',
+      description: 'Unused CSS Rules',
       helpText: 'Remove unused rules from stylesheets to reduce unnecessary ' +
           'bytes consumed by network activity. ' +
           '[Learn more](https://developers.google.com/speed/docs/insights/OptimizeCSSDelivery)',

diff --git a/lighthouse-core/audits/byte-efficiency/uses-optimized-images.js b/lighthouse-core/audits/byte-efficiency/uses-optimized-images.js
@@ -40,7 +40,7 @@ class UsesOptimizedImages extends Audit {
     return {
       category: 'Images',
       name: 'uses-optimized-images',
-      description: 'Avoids unoptimized images',
+      description: 'Unoptimized Images',
       helpText: 'Images should be optimized to save network bytes. ' +
         'The following images could have smaller file sizes when compressed with ' +
         '[WebP](https://developers.google.com/speed/webp/) or JPEG at 80 quality. ' +

diff --git a/lighthouse-core/audits/byte-efficiency/uses-responsive-images.js b/lighthouse-core/audits/byte-efficiency/uses-responsive-images.js
@@ -38,7 +38,7 @@ class UsesResponsiveImages extends Audit {
     return {
       category: 'Images',
       name: 'uses-responsive-images',
-      description: 'Avoids oversized images',
+      description: 'Oversized Images',
       helpText:
         'Image sizes served should be based on the device display size to save network bytes. ' +
         'Learn more about [responsive images](https://developers.google.com/web/fundamentals/design-and-ui/media/images) ' +

diff --git a/lighthouse-core/audits/dobetterweb/link-blocking-first-paint.js b/lighthouse-core/audits/dobetterweb/link-blocking-first-paint.js
@@ -34,7 +34,7 @@ class LinkBlockingFirstPaintAudit extends Audit {
     return {
       category: 'Performance',
       name: 'link-blocking-first-paint',
-      description: 'Avoids `<link>` that delay first paint',
+      description: 'Render-blocking Stylesheets',
       helpText: 'Link elements are blocking the first paint of your page. Consider ' +
           'inlining critical links and deferring non-critical ones. ' +
           '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/blocking-resources).',

diff --git a/lighthouse-core/audits/dobetterweb/script-blocking-first-paint.js b/lighthouse-core/audits/dobetterweb/script-blocking-first-paint.js
@@ -33,7 +33,7 @@ class ScriptBlockingFirstPaint extends Audit {
     return {
       category: 'Performance',
       name: 'script-blocking-first-paint',
-      description: 'Avoids `<script>` in head that delay first paint',
+      description: 'Render-blocking `<script>`',
       helpText: 'Script elements are blocking the first paint of your page. Consider inlining ' +
           'critical scripts and deferring non-critical ones. ' +
           '[Learn more](https://developers.google.com/web/tools/lighthouse/audits/blocking-resources).',

diff --git a/lighthouse-core/config/default.json b/lighthouse-core/config/default.json
@@ -271,13 +271,6 @@
           "description": "Resources made by this application should be severed over HTTP/2 for improved performance."
         }
       }
-    }, {
-      "name": "Using bytes efficiently",
-      "audits": {
-        "unused-css-rules": {},
-        "uses-optimized-images": {},
-        "uses-responsive-images": {}
-      }
     }, {
       "name": "Using modern CSS features",
       "audits": {
@@ -301,12 +294,6 @@
         "no-document-write": {
           "expectedValue": false
         },
-        "link-blocking-first-paint": {
-          "expectedValue": false
-        },
-        "script-blocking-first-paint": {
-          "expectedValue": false
-        },
         "external-anchors-use-rel-noopener": {
           "expectedValue": true
         },
@@ -372,20 +359,19 @@
       }
     }]
   }, {
-    "name": "Performance Metrics",
+    "name": "Performance diagnostics",
     "description": "These encapsulate your app's performance.",
     "scored": false,
     "categorizable": false,
     "items": [{
       "audits": {
-        "critical-request-chains": {
-          "expectedValue": 0,
-          "weight": 1
-        },
-        "user-timings": {
-          "expectedValue": 0,
-          "weight": 1
-        }
+        "unused-css-rules": {},
+        "uses-optimized-images": {},
+        "uses-responsive-images": {},
+        "critical-request-chains": {},
+        "link-blocking-first-paint": {},
+        "script-blocking-first-paint": {},
+        "user-timings": {}
       }
     }]
   }, {

diff --git a/lighthouse-core/formatters/partials/table.html b/lighthouse-core/formatters/partials/table.html
@@ -2,7 +2,7 @@
 
 {{#if rows}}
 <details class="subitem__details">
-  <summary class="subitem__detail">More information</summary>
+  <summary class="subitem__detail">View details</summary>
   <table class="table_list {{#if_not_eq headings.length 2}}multicolumn{{/if_not_eq}}">
     <thead>
       <tr>