fix

GoogleChrome · Jun 7, 2017 · 7938b54 · 7938b54
1 parent 416d4a0
commit 7938b54
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/lighthouse-core/config/plots.json b/lighthouse-core/config/plots.json
@@ -10,7 +10,6 @@
     "first-meaningful-paint",
     "speed-index-metric",
     "estimated-input-latency",
-    "time-to-interactive",
     "first-interactive",
     "consistently-interactive"
   ]

diff --git a/plots/measure.js b/plots/measure.js
@@ -81,7 +81,7 @@ function main() {
   if (args.reuseChrome) {
     ChromeLauncher.launch().then(launcher => {
       return runAnalysisWithExistingChromeInstances(launcher)
-        .catch(err => console.error(err))
+        .catch(handleError)
         .then(() => launcher.kill());
     });
     return;
@@ -110,16 +110,26 @@ function runAnalysisWithNewChromeInstances() {
       promise = promise.then(() => {
         return ChromeLauncher.launch().then(launcher => {
           return singleRunAnalysis(url, id, launcher, {ignoreRun})
-            .catch(err => console.error(err))
+            .catch(handleError)
             .then(() => launcher.kill());
         })
-        .catch(err => console.error(err));
+        .catch(handleError);
       });
     }
   }
   return promise;
 }
 
+/**
+ * @param {!Error} error
+ */
+function handleError(error) {
+  console.error(error);
+  if (process.env.CI) {
+    process.exit(1);
+  }
+}
+
 /**
  * Reuses existing Chrome instance for all site runs.
  * Returns a promise chain that analyzes all the sites n times.
@@ -195,7 +205,7 @@ function analyzeWithLighthouse(launcher, url, outputPath, assetsPath, {ignoreRun
           return Printer.write(lighthouseResults, flags.output, outputPath);
         });
     })
-    .catch(err => console.error(err));
+    .catch(handleError);
 }
 
 /**