Merge remote-tracking branch 'origin/master' into devtools-test-hash

.github/workflows/check-md-links.yml

@@ -0,0 +1,26 @@
+name: Markdown Links Check
+# runs every monday at 9 am
+on:
+  schedule:
+    - cron: "0 9 * * 1"
+
+jobs:
+  check-links:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@master
+      - uses: gaurav-nelson/github-action-markdown-link-check@v1
+        # checks all markdown files from /docs including all subfolders
+        with:
+          use-quiet-mode: 'yes'
+          use-verbose-mode: 'yes'
+          config-file: '.github/workflows/markdown.links.config.json'
+          folder-path: 'docs/'
+      - uses: actions/checkout@master
+      - uses: gaurav-nelson/github-action-markdown-link-check@v1
+        # checks all markdown files from root but ignores subfolders
+        with:
+          use-quiet-mode: 'yes'
+          use-verbose-mode: 'yes'
+          config-file: '.github/workflows/markdown.links.config.json'
+          max-depth: 0

.github/workflows/ci.yml

@@ -153,7 +153,7 @@ jobs:
     - run: sudo apt-get install xvfb
     - name: Run smoke tests
       run: xvfb-run --auto-servernum yarn smoke --debug -j=1 --retries=2 --invert-match ${{ matrix.smoke-test-invert }} $SMOKE_GROUP_1
-  
+
   # Only run smoke tests for windows against stable chrome.
   smoke-windows:
     runs-on: windows-latest

.github/workflows/markdown.links.config.json

@@ -0,0 +1,10 @@
+{
+  "ignorePatterns": [
+    {
+      "pattern": "^http://www.tmeter.ru"
+    },
+    {
+      "pattern": "https://github.com/GoogleChrome/lighthouse/workflows/\uD83D\uDCA1\uD83C\uDFE0/badge.svg"
+    }
+  ]
+}

build/build-dt-report-resources.js

@@ -33,6 +33,8 @@ writeFile('report.js', htmlReportAssets.REPORT_JAVASCRIPT);
 writeFile('report.css', htmlReportAssets.REPORT_CSS);
 writeFile('template.html', htmlReportAssets.REPORT_TEMPLATE);
 writeFile('templates.html', htmlReportAssets.REPORT_TEMPLATES);
+writeFile('report.d.ts', 'export {}');
+writeFile('report-generator.d.ts', 'export {}');
 
 const pathToReportAssets = require.resolve('../clients/devtools-report-assets.js');
 browserify(generatorFilename, {standalone: 'Lighthouse.ReportGenerator'})

docs/readme.md

@@ -133,7 +133,7 @@ $ lighthouse --port=9222 --emulated-form-factor=none --throttling.cpuSlowdownMul
 
 ## Lighthouse as trace processor
 
-Lighthouse can be used to analyze trace and performance data collected from other tools (like WebPageTest and ChromeDriver). The `traces` and `devtoolsLogs` artifact items can be provided using a string for the absolute path on disk if they're saved with `.trace.json` and `.devtoolslog.json` file extensions, respectively. The `devtoolsLogs` array is captured from the `Network` and `Page` domains (a la ChromeDriver's [enableNetwork and enablePage options]((https://sites.google.com/a/chromium.org/chromedriver/capabilities#TOC-perfLoggingPrefs-object)).
+Lighthouse can be used to analyze trace and performance data collected from other tools (like WebPageTest and ChromeDriver). The `traces` and `devtoolsLogs` artifact items can be provided using a string for the absolute path on disk if they're saved with `.trace.json` and `.devtoolslog.json` file extensions, respectively. The `devtoolsLogs` array is captured from the `Network` and `Page` domains (a la ChromeDriver's [enableNetwork and enablePage options](https://sites.google.com/a/chromium.org/chromedriver/capabilities#TOC-perfLoggingPrefs-object)).
 
 As an example, here's a trace-only run that reports on user timings and critical request chains:
 

lighthouse-cli/test/fixtures/perf/delayed-element.js

@@ -32,8 +32,12 @@ setTimeout(() => {
   textEl.textContent = 'Sorry!';
   textEl.style.height = '18px' // this height can be flaky so we set it manually
   const top = document.getElementById('late-content');
-  top.appendChild(imgEl);
-  top.appendChild(textEl);
+
+  // Use shadow DOM to verify devtoolsNodePath resolves through it
+  const shadowRoot = top.attachShadow({mode: 'open'});
+  const sectionEl = document.createElement('section');
+  sectionEl.append(imgEl, textEl);
+  shadowRoot.append(sectionEl);
 
   // layout-shift-elements: ensure we can handle missing shift elements
   if (window.location.href.includes('?missing')) {

lighthouse-cli/test/fixtures/perf/preload_tester.js

@@ -17,13 +17,13 @@ setTimeout(() => {
   // load another origin in a way where the `crossorigin` attribute matters
   const link = document.createElement('link');
   link.rel = 'stylesheet';
-  link.href = 'https://fonts.googleapis.com/css?family=Roboto&display=block';
+  link.href = 'https://fonts.googleapis.com/css?family=Ranchers&display=block';
   document.head.appendChild(link);
 
   link.onload = () => {
     // Make sure LCP is waiting on the network so the above resources are considered important.
     const lcpElement = document.createElement('div');
-    lcpElement.style.fontFamily = 'Roboto';
+    lcpElement.style.fontFamily = 'Ranchers';
     lcpElement.textContent = 'Here is some really tall text!'.repeat(50)
     document.body.appendChild(lcpElement);
   };

lighthouse-cli/test/smokehouse/test-definitions/perf/expectations.js

@@ -172,7 +172,6 @@ module.exports = [
       TraceElements: [
         {
           traceEventType: 'largest-contentful-paint',
-          selector: 'body > div#late-content > img',
           nodeLabel: 'img',
           snippet: '<img src="../dobetterweb/lighthouse-480x318.jpg">',
           boundingRect: {
@@ -201,7 +200,6 @@ module.exports = [
         },
         {
           traceEventType: 'layout-shift',
-          selector: 'body > div#late-content > div',
           nodeLabel: 'Sorry!',
           snippet: '<div style="height: 18px;">',
           boundingRect: {
@@ -254,7 +252,7 @@ module.exports = [
                 node: {
                   type: 'node',
                   nodeLabel: 'img',
-                  selector: 'body > div#late-content > img',
+                  path: '0,HTML,1,BODY,1,DIV,a,#document-fragment,0,SECTION,0,IMG',
                 },
               },
             ],