core(driver): only fail security state if scheme is not cryptographic (…

…#8338)
GoogleChrome · Apr 30, 2019 · 7d04ed7 · 7d04ed7
1 parent 62d8a7b
commit 7d04ed7
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/lighthouse-core/gather/driver.js b/lighthouse-core/gather/driver.js
@@ -912,8 +912,12 @@ class Driver {
       /**
        * @param {LH.Crdp.Security.SecurityStateChangedEvent} event
        */
-      const securityStateChangedListener = ({securityState, explanations}) => {
-        if (securityState === 'insecure') {
+      const securityStateChangedListener = ({
+        securityState,
+        explanations,
+        schemeIsCryptographic,
+      }) => {
+        if (securityState === 'insecure' && schemeIsCryptographic) {
           cancel();
           const insecureDescriptions = explanations
             .filter(exp => exp.securityState === 'insecure')

diff --git a/lighthouse-core/test/gather/driver-test.js b/lighthouse-core/test/gather/driver-test.js
@@ -700,6 +700,31 @@ describe('.gotoURL', () => {
       await loadPromise;
     });
 
+    it('does not reject when page is insecure but http', async () => {
+      const secureSecurityState = {
+        explanations: [],
+        securityState: 'insecure',
+        schemeIsCryptographic: false,
+      };
+
+      driver.on = driver.once = createMockOnceFn()
+        .mockEvent('Security.securityStateChanged', secureSecurityState);
+
+      const startUrl = 'https://www.example.com';
+      const loadOptions = {
+        waitForLoad: true,
+        passContext: {
+          settings: {
+            maxWaitForLoad: 1,
+          },
+        },
+      };
+
+      const loadPromise = driver.gotoURL(startUrl, loadOptions);
+      await flushAllTimersAndMicrotasks();
+      await loadPromise;
+    });
+
     it('rejects when page is insecure', async () => {
       const insecureSecurityState = {
         explanations: [
@@ -717,6 +742,7 @@ describe('.gotoURL', () => {
           },
         ],
         securityState: 'insecure',
+        schemeIsCryptographic: true,
       };
 
       driver.on = driver.once = createMockOnceFn();