core(is-crawlable): always ignore mailto anchors (#11554)

GoogleChrome · Oct 12, 2020 · 7e01883 · 7e01883
1 parent 8f7ade1
commit 7e01883
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/lighthouse-core/audits/seo/crawlable-anchors.js b/lighthouse-core/audits/seo/crawlable-anchors.js
@@ -53,6 +53,8 @@ class CrawlableAnchors extends Audit {
       role = role.trim();
 
       if (role.length > 0) return;
+      // Ignore mailto links even if they use one of the failing patterns. See https://github.com/GoogleChrome/lighthouse/issues/11443#issuecomment-694898412
+      if (rawHref.startsWith('mailto:')) return;
 
       const windowLocationRegExp = /window\.location=/;
       const windowOpenRegExp = /window\.open\(/;

diff --git a/lighthouse-core/test/audits/seo/crawlable-anchors-test.js b/lighthouse-core/test/audits/seo/crawlable-anchors-test.js
@@ -152,4 +152,12 @@ describe('SEO: Crawlable anchors audit', () => {
       assert.equal(auditResult, 1, `'${onclickVariation}' should pass the audit`);
     }
   });
+
+  it('handles window.open in an onclick attribute and mailto: in a href attribute', () => {
+    assert.equal(
+        runAudit({rawHref: 'mailto:name@example.com', onclick: 'window.open()'}),
+        1,
+        'window.open in an onclick and mailto: in a href is a pass'
+    );
+  });
 });