feedback

GoogleChrome · Jul 19, 2017 · 93bed77 · 93bed77
1 parent f0909fc
commit 93bed77
Show file tree

Hide file tree

Showing 8 changed files with 15 additions and 10 deletions.
diff --git a/lighthouse-core/audits/audit.js b/lighthouse-core/audits/audit.js
@@ -35,15 +35,16 @@ class Audit {
   }
 
   /**
-   * Computes and clamps the score between 0 and 100 based on the measured value, and the two control
-   * points on the log-normal distribution (point of diminishing returns and the median value).
+   * Computes a clamped score between 0 and 100 based on the measured value. Score is determined by
+   * considering a log-normal distribution governed by the two control points, point of diminishing
+   * returns and the median value, and returning the percentage of sites that have higher value.
    *
    * @param {number} measuredValue
    * @param {number} diminishingReturnsValue
    * @param {number} medianValue
    * @return {number}
    */
-  static computeScore(measuredValue, diminishingReturnsValue, medianValue) {
+  static computeLogNormalScore(measuredValue, diminishingReturnsValue, medianValue) {
     const distribution = statistics.getLogNormalDistribution(
       medianValue,
       diminishingReturnsValue

diff --git a/lighthouse-core/audits/byte-efficiency/total-byte-weight.js b/lighthouse-core/audits/byte-efficiency/total-byte-weight.js
@@ -71,7 +71,7 @@ class TotalByteWeight extends ByteEfficiencyAudit {
       //   <= 1600KB: score≈100
       //   4000KB: score=50
       //   >= 9000KB: score≈0
-      const score = ByteEfficiencyAudit.computeScore(
+      const score = ByteEfficiencyAudit.computeLogNormalScore(
         totalBytes,
         SCORING_POINT_OF_DIMINISHING_RETURNS,
         SCORING_MEDIAN

diff --git a/lighthouse-core/audits/consistently-interactive.js b/lighthouse-core/audits/consistently-interactive.js
@@ -229,7 +229,11 @@ class ConsistentlyInteractiveMetric extends Audit {
         const extendedInfo = Object.assign(quietPeriodInfo, {timestamp, timeInMs});
 
         return {
-          score: Audit.computeScore(timeInMs, SCORING_POINT_OF_DIMINISHING_RETURNS, SCORING_MEDIAN),
+          score: Audit.computeLogNormalScore(
+            timeInMs,
+            SCORING_POINT_OF_DIMINISHING_RETURNS,
+            SCORING_MEDIAN
+          ),
           rawValue: timeInMs,
           displayValue: Util.formatMilliseconds(timeInMs),
           optimalValue: this.meta.optimalValue,

diff --git a/lighthouse-core/audits/dobetterweb/dom-size.js b/lighthouse-core/audits/dobetterweb/dom-size.js
@@ -72,7 +72,7 @@ class DOMSize extends Audit {
     //   <= 1500: score≈100
     //   3000: score=50
     //   >= 5970: score≈0
-    const score = Audit.computeScore(
+    const score = Audit.computeLogNormalScore(
       stats.totalDOMNodes,
       SCORING_POINT_OF_DIMINISHING_RETURNS,
       SCORING_MEDIAN

diff --git a/lighthouse-core/audits/estimated-input-latency.js b/lighthouse-core/audits/estimated-input-latency.js
@@ -50,7 +50,7 @@ class EstimatedInputLatency extends Audit {
     //  Median = 100ms
     //  75th Percentile ≈ 133ms
     //  95th Percentile ≈ 199ms
-    const score = Audit.computeScore(
+    const score = Audit.computeLogNormalScore(
       ninetieth.time,
       SCORING_POINT_OF_DIMINISHING_RETURNS,
       SCORING_MEDIAN

diff --git a/lighthouse-core/audits/first-interactive.js b/lighthouse-core/audits/first-interactive.js
@@ -41,7 +41,7 @@ class FirstInteractiveMetric extends Audit {
     return artifacts.requestFirstInteractive(trace)
       .then(firstInteractive => {
         return {
-          score: Audit.computeScore(
+          score: Audit.computeLogNormalScore(
             firstInteractive.timeInMs,
             SCORING_POINT_OF_DIMINISHING_RETURNS,
             SCORING_MEDIAN

diff --git a/lighthouse-core/audits/first-meaningful-paint.js b/lighthouse-core/audits/first-meaningful-paint.js
@@ -100,7 +100,7 @@ class FirstMeaningfulPaint extends Audit {
     //   4000ms: score=50
     //   >= 14000ms: score≈0
     const firstMeaningfulPaint = traceOfTab.timings.firstMeaningfulPaint;
-    const score = Audit.computeScore(
+    const score = Audit.computeLogNormalScore(
       firstMeaningfulPaint,
       SCORING_POINT_OF_DIMINISHING_RETURNS,
       SCORING_MEDIAN

diff --git a/lighthouse-core/audits/speed-index-metric.js b/lighthouse-core/audits/speed-index-metric.js
@@ -62,7 +62,7 @@ class SpeedIndexMetric extends Audit {
       //  Median = 5,500
       //  75th Percentile = 8,820
       //  95th Percentile = 17,400
-      const score = Audit.computeScore(
+      const score = Audit.computeLogNormalScore(
         speedline.perceptualSpeedIndex,
         SCORING_POINT_OF_DIMINISHING_RETURNS,
         SCORING_MEDIAN