Skip to content

Commit

Permalink
add descriptions. remove longestChainCount from UI
Browse files Browse the repository at this point in the history
  • Loading branch information
paulirish committed Aug 1, 2018
1 parent 01c3261 commit aa43d3b
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 17 deletions.
12 changes: 6 additions & 6 deletions lighthouse-core/lib/locales/en-US.json
Original file line number Diff line number Diff line change
Expand Up @@ -436,15 +436,15 @@
"description": "Label shown preceding any important warnings that may have invalidated the entire report. For example, if the user has Chrome extensions installed, they may add enough performance overhead that Lighthouse's performance metrics are unreliable. If shown, this will be displayed at the top of the report UI."
},
"lighthouse-core/report/html/renderer/util.js | scorescaleLabel": {
"message": "Score scale:"
"message": "Score scale:",
"description": "Label preceding a pictorial explanation of the scoring scale: 0-50 is red (bad), 50-90 is orange (ok), 90-100 is green (good). These colors are used throughout the report to provide context for how good/bad a particular result is."
},
"lighthouse-core/report/html/renderer/util.js | crcInitialNavigation": {
"message": "Initial Navigation"
"message": "Initial Navigation",
"description": "String of text shown in a graphical representation of the flow of network requests for the web page. This label represents the initial network request that fetches an HTML page. This navigation may be redirected (eg. Initial navigation to http://example.com redirects to https://www.example.com)."
},
"lighthouse-core/report/html/renderer/util.js | crcLongestDurationLabel": {
"message": "Longest chain:"
},
"lighthouse-core/report/html/renderer/util.js | crcTransferSizeLabel": {
"message": "Transfer Size:"
"message": "Maximum critical path latency:",
"description": "Label of value shown in the summary of critical request chains. Refers to the total amount of time (milliseconds) of the longest critical path chain/sequence of network requests. Example value: 2310 ms"
}
}
4 changes: 0 additions & 4 deletions lighthouse-core/report/html/renderer/crc-details-renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -162,10 +162,6 @@ class CriticalRequestChainRenderer {
Util.UIStrings.crcLongestDurationLabel;
dom.find('.lh-crc__longest_duration', tmpl).textContent =
Util.formatMilliseconds(details.longestChain.duration);
dom.find('.lh-crc__longest_transfersize_label', tmpl).textContent =
Util.UIStrings.crcTransferSizeLabel;
dom.find('.lh-crc__longest_transfersize', tmpl).textContent =
Util.formatBytesToKB(details.longestChain.transferSize);

// Construct visual tree.
const root = CriticalRequestChainRenderer.initTree(details.chains);
Expand Down
5 changes: 3 additions & 2 deletions lighthouse-core/report/html/renderer/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -397,9 +397,10 @@ Util.UIStrings = {
/** Label preceding a pictorial explanation of the scoring scale: 0-50 is red (bad), 50-90 is orange (ok), 90-100 is green (good). These colors are used throughout the report to provide context for how good/bad a particular result is. */
scorescaleLabel: 'Score scale:',

/** String of text shown in a graphical representation of the flow of network requests for the web page. This label represents the initial network request that fetches an HTML page. This navigation may be redirected (eg. Initial navigation to http://example.com redirects to https://www.example.com). */
crcInitialNavigation: 'Initial Navigation',
crcLongestDurationLabel: 'Longest chain:',
crcTransferSizeLabel: 'Transfer Size:',
/** Label of value shown in the summary of critical request chains. Refers to the total amount of time (milliseconds) of the longest critical path chain/sequence of network requests. Example value: 2310 ms */
crcLongestDurationLabel: 'Maximum critical path latency:',
};

if (typeof module !== 'undefined' && module.exports) {
Expand Down
3 changes: 0 additions & 3 deletions lighthouse-core/report/html/templates.html
Original file line number Diff line number Diff line change
Expand Up @@ -615,9 +615,6 @@
<div class="lh-crc__summary-value">
<span class="lh-crc__longest_duration_label"></span> <b class="lh-crc__longest_duration"></b>
</div>
<div class="lh-crc__summary-value">
<span class="lh-crc__longest_transfersize_label"></span> <b class="lh-crc__longest_transfersize"></b>
</div>
</div>
<div class="lh-crc">
<div class="crc-initial-nav"></div>
Expand Down
3 changes: 1 addition & 2 deletions lighthouse-core/test/results/sample_v2.json
Original file line number Diff line number Diff line change
Expand Up @@ -3388,8 +3388,7 @@
"toplevelWarningsMessage": "There were issues affecting this run of Lighthouse:",
"scorescaleLabel": "Score scale:",
"crcInitialNavigation": "Initial Navigation",
"crcLongestDurationLabel": "Longest chain:",
"crcTransferSizeLabel": "Transfer Size:"
"crcLongestDurationLabel": "Maximum critical path latency:"
},
"icuMessagePaths": {
"lighthouse-core/audits/metrics/first-contentful-paint.js | title": [
Expand Down

0 comments on commit aa43d3b

Please sign in to comment.