core(has-inspector-issues): rename to inspector-issues (#11710)

lighthouse-cli/test/cli/__snapshots__/index-test.js.snap

@@ -403,7 +403,7 @@ Object {
       "path": "dobetterweb/geolocation-on-start",
     },
     Object {
-      "path": "dobetterweb/has-inspector-issues",
+      "path": "dobetterweb/inspector-issues",
     },
     Object {
       "path": "dobetterweb/no-document-write",
@@ -805,7 +805,7 @@ Object {
         },
         Object {
           "group": "best-practices-general",
-          "id": "has-inspector-issues",
+          "id": "inspector-issues",
           "weight": 1,
         },
       ],

lighthouse-core/audits/dobetterweb/has-inspector-issues.js → lighthouse-core/audits/dobetterweb/inspector-issues.js

@@ -43,7 +43,7 @@ class IssuesPanelEntries extends Audit {
    */
   static get meta() {
     return {
-      id: 'has-inspector-issues',
+      id: 'inspector-issues',
       title: str_(UIStrings.title),
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),

lighthouse-core/config/default-config.js

@@ -319,7 +319,7 @@ const defaultConfig = {
     'dobetterweb/dom-size',
     'dobetterweb/external-anchors-use-rel-noopener',
     'dobetterweb/geolocation-on-start',
-    'dobetterweb/has-inspector-issues',
+    'dobetterweb/inspector-issues',
     'dobetterweb/no-document-write',
     'dobetterweb/no-vulnerable-libraries',
     'dobetterweb/js-libraries',
@@ -575,7 +575,7 @@ const defaultConfig = {
         {id: 'deprecations', weight: 1, group: 'best-practices-general'},
         {id: 'errors-in-console', weight: 1, group: 'best-practices-general'},
         {id: 'valid-source-maps', weight: 0, group: 'best-practices-general'},
-        {id: 'has-inspector-issues', weight: 1, group: 'best-practices-general'},
+        {id: 'inspector-issues', weight: 1, group: 'best-practices-general'},
       ],
     },
     'seo': {

lighthouse-core/test/audits/dobetterweb/has-inspector-issues-test.js → lighthouse-core/test/audits/dobetterweb/inspector-issues-test.js

@@ -6,7 +6,7 @@
 'use strict';
 
 const InspectorIssuesAudit =
-  require('../../../audits/dobetterweb/has-inspector-issues.js');
+  require('../../../audits/dobetterweb/inspector-issues.js');
 
 /* eslint-env jest */
 

lighthouse-core/test/results/sample_v2.json

@@ -3774,8 +3774,8 @@
         ]
       }
     },
-    "has-inspector-issues": {
-      "id": "has-inspector-issues",
+    "inspector-issues": {
+      "id": "inspector-issues",
       "title": "No issues in the `Issues` panel in Chrome Devtools",
       "description": "Issues logged to the `Issues` panel in Chrome Devtools indicate unresolved problems. They can come from network request failures, insufficient security controls, and other browser concerns. Open up the Issues panel in Chrome DevTools for more details on each issue.",
       "score": null,
@@ -5075,7 +5075,7 @@
           "group": "best-practices-general"
         },
         {
-          "id": "has-inspector-issues",
+          "id": "inspector-issues",
           "weight": 1,
           "group": "best-practices-general"
         }
@@ -6412,7 +6412,7 @@
       },
       {
         "startTime": 0,
-        "name": "lh:audit:has-inspector-issues",
+        "name": "lh:audit:inspector-issues",
         "duration": 100,
         "entryType": "measure"
       },
@@ -7789,11 +7789,11 @@
         "audits[notification-on-start].details.headings[1].text",
         "audits[uses-passive-event-listeners].details.headings[1].text"
       ],
-      "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | title": [
-        "audits[has-inspector-issues].title"
+      "lighthouse-core/audits/dobetterweb/inspector-issues.js | title": [
+        "audits[inspector-issues].title"
       ],
-      "lighthouse-core/audits/dobetterweb/has-inspector-issues.js | description": [
-        "audits[has-inspector-issues].description"
+      "lighthouse-core/audits/dobetterweb/inspector-issues.js | description": [
+        "audits[inspector-issues].description"
       ],
       "lighthouse-core/audits/dobetterweb/no-document-write.js | failureTitle": [
         "audits[no-document-write].title"

third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-export-run-expected.txt

@@ -2,11 +2,11 @@ Tests that exporting works.
 
 ++++++++ testExportHtml
 
-# of .lh-audit divs (original): 136
+# of .lh-audit divs (original): 137
 
-# of .lh-audit divs (exported html): 136
+# of .lh-audit divs (exported html): 137
 
 ++++++++ testExportJson
 
-# of audits (json): 152
+# of audits (json): 153
 

third-party/chromium-webtests/webtests/http/tests/devtools/lighthouse/lighthouse-successful-run-expected.txt

@@ -461,7 +461,6 @@ form-field-multiple-labels: notApplicable
 frame-title: notApplicable
 geolocation-on-start: pass
 gpt-bids-parallel: notApplicable
-has-inspector-issues: pass
 heading-order: notApplicable
 hreflang: pass
 html-has-lang: fail
@@ -471,6 +470,7 @@ image-alt: notApplicable
 image-aspect-ratio: pass
 image-size-responsive: pass
 input-image-alt: notApplicable
+inspector-issues: pass
 installable-manifest: fail
 interactive: flaky
 interactive-element-affordance: manual
@@ -676,7 +676,7 @@ js-libraries
 deprecations
 errors-in-console
 valid-source-maps
-has-inspector-issues
+inspector-issues
 preload-fonts
 viewport
 font-size