Enable CPU throttling (4.5x) (#1778)

GoogleChrome · Mar 14, 2017 · ade2d88 · ade2d88
1 parent 338b09e
commit ade2d88
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/lighthouse-cli/bin.ts b/lighthouse-cli/bin.ts
@@ -126,7 +126,7 @@ Example: --output-path=./lighthouse-results.html`,
 
   // default values
   .default('chrome-flags', '')
-  .default('disable-cpu-throttling', true)
+  .default('disable-cpu-throttling', false)
   .default('output', Printer.GetValidOutputOptions()[Printer.OutputMode.html])
   .default('port', 9222)
   .default('max-wait-for-load', Driver.MAX_WAIT_FOR_FULLY_LOADED)

diff --git a/lighthouse-core/gather/gather-runner.js b/lighthouse-core/gather/gather-runner.js
@@ -313,9 +313,8 @@ class GatherRunner {
       return Promise.reject(new Error('You must provide a config'));
     }
 
-    // CPU throttling is temporarily off by default
     if (typeof options.flags.disableCpuThrottling === 'undefined') {
-      options.flags.disableCpuThrottling = true;
+      options.flags.disableCpuThrottling = false;
     }
 
     passes = this.instantiateGatherers(passes, options.config.configDir);

diff --git a/lighthouse-core/lib/emulation.js b/lighthouse-core/lib/emulation.js
@@ -67,7 +67,7 @@ const NO_CPU_THROTTLE_METRICS = {
   rate: 1
 };
 const CPU_THROTTLE_METRICS = {
-  rate: 5
+  rate: 4.5
 };
 
 function enableNexus5X(driver) {

diff --git a/lighthouse-extension/app/src/popup.js b/lighthouse-extension/app/src/popup.js
@@ -126,9 +126,6 @@ function onGenerateReportButtonClick(background, selectedAggregations) {
       .filter(key => !!selectedAggregations[key]);
 
   background.runLighthouseInExtension({
-    flags: {
-      disableCpuThrottling: true
-    },
     restoreCleanState: true
   }, aggregationIDs).catch(err => {
     let message = err.message;