unmute some smoke test failures

also update smoke test expectations for changes in perf metric scoring
GoogleChrome · Nov 30, 2016 · d0d8cf5 · d0d8cf5
1 parent 31637d7
commit d0d8cf5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/lighthouse-cli/test/smokehouse/offline-local/offline-expectations.js b/lighthouse-cli/test/smokehouse/offline-local/offline-expectations.js
@@ -33,8 +33,8 @@ module.exports = [
       'viewport': true,
       'manifest-display': false,
       'without-javascript': true,
-      'user-timings': 0,
-      'critical-request-chains': 1,
+      'user-timings': true,
+      'critical-request-chains': false,
       'manifest-exists': false,
       'manifest-background-color': false,
       'manifest-theme-color': false,
@@ -66,8 +66,8 @@ module.exports = [
       'viewport': true,
       'manifest-display': false,
       'without-javascript': true,
-      'user-timings': 0,
-      'critical-request-chains': 1,
+      'user-timings': true,
+      'critical-request-chains': false,
       'manifest-exists': false,
       'manifest-background-color': false,
       'manifest-theme-color': false,

diff --git a/package.json b/package.json
@@ -12,7 +12,7 @@
   },
   "scripts": {
     "lint": "[ \"$CI\" = true ] && eslint --quiet . || eslint .",
-    "smoke": "lighthouse-cli/test/smokehouse/offline-local/run-tests.sh; lighthouse-cli/test/smokehouse/dobetterweb/run-tests.sh",
+    "smoke": "lighthouse-cli/test/smokehouse/offline-local/run-tests.sh && lighthouse-cli/test/smokehouse/dobetterweb/run-tests.sh",
     "coverage": "node $__node_harmony $(npm bin)/istanbul cover -x \"**/third_party/**\" _mocha -- $(find */test -name '*-test.js') --timeout 10000 --reporter progress",
     "coveralls": "npm run coverage && cat ./coverage/lcov.info | coveralls",
     "start": "node ./lighthouse-cli/index.js",