Skip to content

Commit

Permalink
driver: add compat comment on PerfObserver GC bug
Browse files Browse the repository at this point in the history
  • Loading branch information
paulirish committed Aug 4, 2017
1 parent 78a8bd7 commit d7ffec1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions lighthouse-core/gather/driver.js
Original file line number Diff line number Diff line change
Expand Up @@ -1118,6 +1118,8 @@ function registerPerformanceObserverInPage() {
// HACK: A PerformanceObserver will be GC'd if there are no more references to it, so attach it to
// window to ensure we still receive longtask notifications. See https://crbug.com/742530.
// For an example test of this behavior see https://gist.github.com/patrickhulce/69d8bed1807e762218994b121d06fea6.
// FIXME COMPAT: This hack isn't neccessary as of Chrome 62.0.3176.0
// https://bugs.chromium.org/p/chromium/issues/detail?id=742530#c7
window.____lhPerformanceObserver = observer;
}

Expand Down

0 comments on commit d7ffec1

Please sign in to comment.